Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-08-01] [Payment card / Subscription] Follow up to #44362 #45942

Closed
blimpich opened this issue Jul 22, 2024 · 5 comments
Closed

[HOLD for payment 2024-08-01] [Payment card / Subscription] Follow up to #44362 #45942

blimpich opened this issue Jul 22, 2024 · 5 comments
Assignees
@blimpich
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@blimpich
Copy link
Contributor

Following up from this comment, we missed a line when completing #44362.

Lets fix it.
@blimpich blimpich self-assigned this Jul 22, 2024
@blimpich blimpich changed the title Follow up to #44362 [Payment card / Subscription] Follow up to #44362 Jul 22, 2024
This was referenced Jul 22, 2024
Merged
Closed
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Jul 22, 2024
@melvin-bot melvin-bot bot changed the title [Payment card / Subscription] Follow up to #44362 [HOLD for payment 2024-08-01] [Payment card / Subscription] Follow up to #44362 Jul 25, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 25, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 25, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 25, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-01. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 31, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 1, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot melvin-bot bot added the Overdue label Aug 2, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 5, 2024

@blimpich Huh... This is 4 days overdue. Who can take care of this?

@blimpich
Copy link
Contributor Author

blimpich commented Aug 5, 2024

This was deployed to production, closing.

@blimpich blimpich closed this as completed Aug 5, 2024
@melvin-bot melvin-bot bot removed the Overdue label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blimpich blimpich

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
[#whatsnext] #wave-collect
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blimpich