[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Payment card / Subscription] fix card data not showing up in the new subscription page

[blimpich]

Problem

Right now if you add a card to your existing subscription via https://dev.new.expensify.com:8082/settings/subscription/add-payment-card it'll not show anything. There are multiple issues here causing this, but they are small enough to be combined into this one use case.

The first problem is explained in this slack thread. Basically we are not properly initializing the fundList in the Onyx db on the client. We need to fix that.

The second problem is that after this was completed we never updated App's code to make use of the new format of the data, which means it doesn't show the default card.

Solution

Fix both of the described problems above and make a newly added payment card show up in the UI.

Issue Owner

Current Issue Owner: @abekkala

[blimpich]

Web-PR is in review, App PR is on hold until Web-PR is merged and deployed

[blimpich]

Web PR is merged, waiting deploy.

App PR is in review, waiting approval but also waiting web changes to be deployed before a proper review can happen.

[blimpich]

Web PR was deployed to staging, waiting deploy to production

[trjExpensify]

App PR has merged: #44361

Adding labels to get a BZ assigned, and @brunovjk as the C+ reviewer.

[melvin-bot]

Triggered auto assignment to @abekkala (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[blimpich]

This is done.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• update default card onyx data accessing #44361

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @brunovjk requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@brunovjk] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• update default card onyx data accessing #44361

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @brunovjk requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@brunovjk] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[pac-guerreiro]

Hey, this line of code was missed in @blimpich PR - https://github.com/Expensify/App/blob/main/src/libs/SubscriptionUtils.ts#L206

Not his fault, this one was sneaky 😅

The specific line of code doesn't cause the error reported in this issue but it will not trigger card expired related UI.

I can create a PR for this if you want 😄

[blimpich]

Ah, thank you for catching that @pac-guerreiro! I'll make a quick issue/PR for it right now 👍

[blimpich]

Created issue here for tracking this follow up. PR is up and I'm gonna do some testing before getting it out for review.

[blimpich]

Also no regression tests should be needed for this issue. @abekkala correct me if I'm wrong but I think we need to pay @brunovjk for reviewing this PR? I think that was my mistake for closing this PR too soon.

[abekkala]

@blimpich ah yes, I can send payment offer to @brunovjk for reviewing this PR: #44361

I assume that is a $250 review?

[blimpich]

Yes $250

[abekkala]

@brunovjk offer sent!

[brunovjk]

thank you all :D

[abekkala]

@brunovjk payment sent and contract ended - thank you! 🎉