Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - All group participants are not displayed in the Split bill attendees #4501

Closed
isagoico opened this issue Aug 7, 2021 · 18 comments
Closed
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@isagoico
Copy link

isagoico commented Aug 7, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue is failing PR #3881 on Android

Action Performed:

  1. Navigate to a group that has more than 4 participants
  2. Tap on split bill
  3. Deselect a select attendees randomly

Expected Result:

User should be able to scroll the list of attendees to select and deselect the required ones.

Actual Result:

User is unable to scroll the list of attendees. Only 4 attendees are displayed at all times, even when the group has more than 4 group participants.

Workaround:

Unknown.

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.0.83-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

SVID_20210807_121823_1.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@isagoico isagoico added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Aug 7, 2021
@MelvinBot
Copy link

Triggered auto assignment to @Jag96 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Aug 7, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Aug 7, 2021

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@rushatgabhane
Copy link
Member

@isagoico
Just to clarify, this bug isn't caused due to the PR #3881.
Because the bug is present in production too. And the PR isn't deployed to production.

v1.0.82-7 from play store.

production.mp4

Also, sorry for late reply. I didn't get any notification.

@isagoico
Copy link
Author

isagoico commented Aug 9, 2021

Oh ok. I thought the PR was a fail because of this. Removing the deploy blocker label. Tagging both PR reviewers just in case. CC @marcaaron @Luke9389

@isagoico isagoico removed the DeployBlockerCash This issue or pull request should block deployment label Aug 9, 2021
@marcaaron
Copy link
Contributor

Ah sorry, I don't know much about this cc @Luke9389

@Jag96
Copy link
Contributor

Jag96 commented Aug 9, 2021

Removing the hourly label here since this isn't a deploy blocker and putting into the AutoAssigner queue

@Jag96 Jag96 removed the Hourly KSv2 label Aug 9, 2021
@Jag96 Jag96 removed their assignment Aug 9, 2021
@Jag96 Jag96 added AutoAssignerTriage Auto assign issues for triage to an available triage team member and removed Engineering labels Aug 9, 2021
@MelvinBot
Copy link

Triggered auto assignment to @stephanieelliott (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot added Daily KSv2 and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member labels Aug 9, 2021
@Luke9389
Copy link
Contributor

Luke9389 commented Aug 9, 2021

We may want to wait on this until #3881 is deployed to production because it contains a pretty significant refactor of this view.

@parasharrajat
Copy link
Member

@Luke9389 this is a regression from #3881.

@Luke9389
Copy link
Contributor

Luke9389 commented Aug 9, 2021

@rushatgabhane claims it's occurring on production as well. @isagoico can we test production for this?

@parasharrajat
Copy link
Member

Oh yeah. I missed that part. Sorry Rushat 😅

@isagoico
Copy link
Author

Confirmed this is also happening in Prod version

@stephanieelliott
Copy link
Contributor

Issue is complete. reproducible, and worth fixing, moving on to Engineering.

@stephanieelliott stephanieelliott removed their assignment Aug 11, 2021
@stephanieelliott stephanieelliott removed the Daily KSv2 label Aug 11, 2021
@MelvinBot
Copy link

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@joelbettner
Copy link
Contributor

This looks like it has what it needs. Un-assigning myself.

@joelbettner joelbettner removed their assignment Aug 12, 2021
@joelbettner joelbettner added the External Added to denote the issue can be worked on by a contributor label Aug 12, 2021
@MelvinBot
Copy link

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot MelvinBot added Daily KSv2 and removed Weekly KSv2 labels Aug 12, 2021
@parasharrajat
Copy link
Member

This is not happening on the latest code.

@kadiealexander
Copy link
Contributor

kadiealexander commented Aug 13, 2021

@parasharrajat is right, I tested on 1.0.85-0 and this seems to be resolved:

w_a17d6828960171ea40c4c0bba50ed00f5924041a.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests