[$250] IOU - Multiple IOUs are unapproved when a single IOU is unapproved

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): natnael.expensify+0a89fdndafadf@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: Create workspace > More features > Enable workflow > Enable Add approvals > Make yourself approver

1. Navigate to a workspace chat
2. Submit 2 manual requests with different amounts
3. Click on the IOU preview component
4. Click Approve button
5. Click on the IOUs
6. Click header
7. Click unapprove
8. Navigate back to expense report

Expected Result:

Only the unapproved report should be unapproved

Actual Result:

Both IOUs are unapproved

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6535812_1720442435170.Screen_Recording_2024-07-08_at_3.29.15_in_the_afternoon.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0166593468459204f3
• Upwork Job ID: 1810443215436393315
• Last Price Increase: 2024-07-08

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@lschurr I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

[lschurr]

Hi hi @stitesExpensify - Can you check on this and confirm if it's a deploy blocker? Do we need to add External here?

[stitesExpensify]

Checking

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0166593468459204f3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[stitesExpensify]

Commented here #44229

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

All transactions are unapproved when a single transaction is unapproved.

What is the root cause of that problem?

The approve option is available on the expense report which will approve all the transactions, so it makes sense if unapprove will unapprove all transactions too. They both work on the expense report level, not on each transaction.

So, I think the real issue here is that the Unapprove option is shown on the transaction thread details page. That's because when we check whether the report is a money request report or not, we always pass the money request report itself, which is true for the transaction thread too.

App/src/pages/ReportDetailsPage.tsx

Lines 202 to 205 in 7b558ef

	const canUnapproveRequest =
	ReportUtils.isMoneyRequestReport(moneyRequestReport) &&
	(ReportUtils.isReportManager(moneyRequestReport) || isPolicyAdmin) &&
	(ReportUtils.isReportApproved(moneyRequestReport) || ReportUtils.isReportManuallyReimbursed(moneyRequestReport));

The moneyRequestReport variable holds the parentx money request report of the transaction.

App/src/pages/ReportDetailsPage.tsx

Lines 184 to 189 in 7b558ef

	const moneyRequestReport: OnyxEntry<OnyxTypes.Report> = useMemo(() => {
	if (caseID === CASES.MONEY_REQUEST) {
	return parentReport;
	}
	return report;
	}, [caseID, parentReport, report]);

What changes do you think we should make in order to solve the problem?

We should check for the current report instead of the moneyRequestReport.

App/src/pages/ReportDetailsPage.tsx

Lines 202 to 205 in 7b558ef

	const canUnapproveRequest =
	ReportUtils.isMoneyRequestReport(moneyRequestReport) &&
	(ReportUtils.isReportManager(moneyRequestReport) || isPolicyAdmin) &&
	(ReportUtils.isReportApproved(moneyRequestReport) || ReportUtils.isReportManuallyReimbursed(moneyRequestReport));

ReportUtils.isMoneyRequestReport(report) && ...

[suneox]

Thank @bernhardoj for the proposal. I’ll start reviewing it.

[suneox]

I’m still stuck when trying to approve an expense due to the requirement to add a payment card. I have tried a lot of test cards provided by stripe, bluesnap, plaid but none of them worked.
@stitesExpensify, do you have documentation on how to bypass the “add payment card” step in a dev environment?

[Beamanator]

Fix merged & CPing

[Beamanator]

Should be good now, IOUs are no longer Unapprovable 👍 tested in 9.0.5-6 👍

[Beamanator]

Keeping open so @bernhardoj can get paid for his solution here that I implemented in #45049 (along with another small change) 🙏 - cc @lschurr

[melvin-bot]

@Beamanator, @suneox, @lschurr, @stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Beamanator]

@lschurr can you help us retest? This should have been fixed already

[lschurr]

Yes, I'm a bit behind but can test tomorrow - @bernhardoj @suneox are you able to jump in and test this?

[bernhardoj]

Tested on staging, the Unapprove button doesn't show on the transaction thread anymore 🎉

web.mp4

[lschurr]

Woop! Amazing. Is there a PR associated with this specific GH that requires payment or are we good to close?

[Beamanator]

PR was #45049! But it fixed multiple issues FYI 🙏

[lschurr]

Ok, so payment is being issued elsewhere? Or do we need to pay here @Beamanator?

[melvin-bot]

@Beamanator @suneox @lschurr @stitesExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[garrettmknight]

@lschurr I think it's just payment for @bernhardoj here via this comment.

[lschurr]

Great, thanks!

Payment summary:

• Contributor: @bernhardoj $250 (please request in NewDot)

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @bernhardoj