[HOLD for payment 2024-07-24] [$250] Track expense - LHN of self-DM still shows actionable whisper after submitted to someone

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2990401
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: on self-DM click '+' > Track Expense

1. On the actionable whisper options click on 'Submit it to someone'
2. Choose another user and Submit

Expected Result:

The transaction is moved to that new chat.
Tracked expense is not displayed in the self DM anymore.
LHN of self-DM no longer shows "What would you like to do with this expense?"

Actual Result:

The transaction is moved to that new chat.
Tracked expense is not displayed in the self DM anymore.
LHN of self-DM still shows "What would you like to do with this expense?"

Workaround:

Unnkown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6521590_1719068458775.LHN_preview.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01112f075346c9b0f8
• Upwork Job ID: 1805265765671190738
• Last Price Increase: 2024-06-24
• Automatic offers:
• dominictb | Contributor | 102920804

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The transaction is moved to that new chat.
Tracked expense is not displayed in the self DM anymore.
LHN of self-DM still shows "What would you like to do with this expense?"

What is the root cause of that problem?

• Our function isResolvedActionTrackExpense:
  

  App/src/libs/ReportActionsUtils.ts

  Lines 672 to 675 in 4dc1710

  	function isResolvedActionTrackExpense(reportAction: OnyxEntry<ReportAction>): boolean {
  	const resolution = reportAction && 'resolution' in reportAction ? reportAction?.resolution : null;
  	return isActionableTrackExpense(reportAction) && !!resolution;
  	}

  does not work properly because there is no reportAction?.resolution.

• That leads to this logic is wrong:
  

  App/src/libs/OptionsListUtils.ts

  Line 313 in 4dc1710

  !ReportActionUtils.isResolvedActionTrackExpense(reportAction),

What changes do you think we should make in order to solve the problem?

• We need to update:
  

  App/src/libs/ReportActionsUtils.ts

  Lines 672 to 675 in 4dc1710

  	function isResolvedActionTrackExpense(reportAction: OnyxEntry<ReportAction>): boolean {
  	const resolution = reportAction && 'resolution' in reportAction ? reportAction?.resolution : null;
  	return isActionableTrackExpense(reportAction) && !!resolution;
  	}

  
  to:

function isResolvedActionTrackExpense(reportAction: OnyxEntry<ReportAction>): boolean {
    const originalMessage = getOriginalMessage(reportAction);
    const resolution = originalMessage?.resolution ?? null;
    return isActionableTrackExpense(reportAction) && !!resolution;
}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01112f075346c9b0f8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

@slafortune, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[slafortune]

@allroundexperts are you able to get to the review of the proposal here?

[allroundexperts]

On it today.

[allroundexperts]

@dominictb Can you please explain what the getOriginalMessage function is doing?

[dominictb]

@allroundexperts We added getOriginalMessage in phase 1 in this plan:

App/src/libs/ReportActionsUtils.ts

Lines 176 to 181 in e78c38e

	function getOriginalMessage<T extends ReportActionName>(reportAction: OnyxInputOrEntry<ReportAction<T>>): OriginalMessage<T> | undefined {
	if (!Array.isArray(reportAction?.message)) {
	return reportAction?.message ?? reportAction?.originalMessage;
	}
	return reportAction.originalMessage;
	}

As we can see, we can get the reportAction.originalMessage data with this function.

[allroundexperts]

Got it. Thanks for the explanation.

[allroundexperts]

@dominictb's proposal looks good to me. It has the correct RCA and the solution seems to work as well.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dominictb]

@allroundexperts PR #44684 is opened.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: LHN of self-DM still shows actionable whisper after submitted #44684

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[slafortune]

@allroundexperts can you please complete the checklist?

[allroundexperts]

Checklist

1. I was not able to find the exact PR that caused this issue.
2. N/A
3. N/A
4. A regression test would be good to have.

Regression test

1. Open the chat with self, and click '+' > Track Expense
2. On the actionable whisper options click on 'Submit it to someone'
3. Choose another user and Submit

Verify that the transaction is moved to that new chat and tracked expense is not displayed in the self DM anymore.
Also verify that the LHN of self-DM no longer shows "What would you like to do with this expense?"

Do we 👍 or 👎 ?

[melvin-bot]

@slafortune, @allroundexperts, @aldo-expensify, @dominictb Eep! 4 days overdue now. Issues have feelings too...

[slafortune]

@allroundexperts role C+ - requires payment through NewDot Manual Requests of $250
@dominictb role contributor - Paid $250 via Upworks

[JmillsExpensify]

$250 approved for @allroundexperts