Add comment grouping by author

[tgolen]

I wonder if this is because we are reversing the list of reports when they are viewed?

[AndrewGable]

Example:

1	2

[quinthar]

This feels like a very visible kind of polish that people will notice if we don't do, but can live without in a bind. Marking HIGH

[quinthar]

This is currently disabled; updating this to instead to fix it and re-enable

[quinthar]

In the spirit of a feature freeze, demoting to LOW and removing from the milestone.

[sketchydroide]

I think I had a similar issue when doing this on mobile, and it was due to the reversing of the report items, so I would assume that this is the case here as well

[tgolen]

@sketchydroide The code for this is here: https://github.com/Expensify/ReactNativeChat/blob/a1d04df57d481241f97c4e4b1aab18062d2b400a/src/page/HomePage/Report/ReportHistoryView.js#L62-L80

It just needs re-enabled and then have the logic fixed.

[sketchydroide]

I think that I can't replicate the problem anymore, maybe there were some changes to history items themselves? Here is what it is looking like now after I re-enabled and fixed the UI issues.

Web	ReactNative

[tgolen]

Yeah, it's entirely possible that the logic is fine now.

…

On Wed, Aug 26, 2020 at 10:22 AM Andre Fonseca ***@***.***> wrote: I think that I can't replicate the problem anymore, maybe there were some changes to history items themselves? Here is what it is looking like now after I re-enabled and fixed the UI issues. Web ReactNative [image: Screenshot 2020-08-26 at 17 19 19] <https://user-images.githubusercontent.com/242568/91329865-96ebe300-e7c0-11ea-89ce-8872c19ec8da.png> [image: Screenshot 2020-08-26 at 17 19 30] <https://user-images.githubusercontent.com/242568/91329883-9c492d80-e7c0-11ea-8075-f6eeff68a653.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#44 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB4IRER4TW5MG5IM4FLSCUZF5ANCNFSM4P2NGJFQ> .