[$250] Changing "Purchase bill date" clears "Purchase bill status" Authorised value

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when validating #41583
Version Number: 1.4.74-2
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Log in with a new expensifail account
2. Create a workspace
3. Enable accounting from the Workspace settings
4. Connect to Xero
5. Navigate to Workspace settings - Accounting - Export - Purchase bill date
6. Change it to a different value
7. Log out
8. Log in with the same account
9. Navigate to Workspace settings - Accounting - Expor

Expected Result:

The value shouldn't clear.

Actual Result:

Changing "Purchase bill date" clears "Purchase bill status" Authorised value. I'm unable to set any value for the field.
NOTE : We are not sure it is intended

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6483020_1715886859158.bandicam_2024-05-16_21-03-00-340.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011cccc97f51a7d2bb
• Upwork Job ID: 1793075720142639104
• Last Price Increase: 2024-05-22

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011cccc97f51a7d2bb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[greg-schroeder]

Adding to #wave-collect as this is a Xero bug

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

1. Changing "Purchase bill date" clears "Purchase bill status" value after re-logging in
2. Unable to set any value for the field

What is the root cause of that problem?

1. The BE does not return the policy purchase bill status in connections.xero.config.billStatus.purchase even though the Pusher did on syncing the data
2. We set onPress as void:

App/src/pages/workspace/accounting/xero/export/XeroExportConfigurationPage.tsx

Lines 61 to 62 in a905b59

	description: translate('workspace.xero.advancedConfig.purchaseBillStatusTitle'),
	onPress: () => {},

What changes do you think we should make in order to solve the problem?

1. Fix the BE
2. I'm not sure the expected behavior here as I don't have access to the design doc:

• Allow mutability for purchase bill status, we should create a separate page for it and set the above onPress accordingly
• Otherwise we should add shouldShowRightIcon: false, interactive: false to block mutation and interaction
• If the purchase bill status is evaluated based on other fields like purchase bill date... we should update the same in the corresponding action function

What alternative solutions did you explore? (Optional)

NA

[getusha]

Trying to reproduce the issue

[getusha]

🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[getusha]

@luacmartins could you please check if this is something we can fix on the BE? thanks! #42317 (comment)

[luacmartins]

Yea, this seems like internal work cc @lakchote

[melvin-bot]

@luacmartins, @greg-schroeder, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

[greg-schroeder]

This is internal, no update just yet - @lakchote are you across this?

[lakchote]

@greg-schroeder @luacmartins @kavimuru @getusha not a bug, and no BE fix needed.

Testing needed to be done on the ad hoc build, since there was the merge freeze.

You can test it out here: https://42340.pr-testing.expensify.com/ (PR)

I've tested it there, and the value for Purchase bill status doesn't clear out, and we can choose different values for it.

[luacmartins]

Nice, so can we just close this issue then?

[lakchote]

Nice, so can we just close this issue then?

Yes, I'm closing it