Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment + Bonus Aug 18] Change site and app titles to New Expensify #4213

Closed
5 tasks done
isagoico opened this issue Jul 24, 2021 · 14 comments · Fixed by #4408
Closed
5 tasks done

[HOLD for payment + Bonus Aug 18] Change site and app titles to New Expensify #4213

isagoico opened this issue Jul 24, 2021 · 14 comments · Fixed by #4408
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@isagoico
Copy link

isagoico commented Jul 24, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Upwork link: https://www.upwork.com/jobs/~01002fbd8522fb9614


Action Performed:

  1. Log in to staging.new.expensify.com or download latest app build
  2. Check tab title

Expected Result:

Expensify.cash should not be mentioned. New Expensify should be the site title.

Actual Result:

Site title is still Expensify.cash.

Workaround:

None needed.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.0.80-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Web:

image

Android:

image

Desktop:

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@MelvinBot
Copy link

Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@MelvinBot
Copy link

@timszot Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@timszot timszot removed their assignment Jul 27, 2021
@MelvinBot MelvinBot removed the Overdue label Jul 27, 2021
@timszot timszot added the External Added to denote the issue can be worked on by a contributor label Jul 27, 2021
@MelvinBot
Copy link

Triggered auto assignment to @Jag96 (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@timszot
Copy link
Contributor

timszot commented Jul 27, 2021

Looks good to me, adding External

@parasharrajat
Copy link
Member

There are 197 references of Expensify.cash in the source. Out of which, I think nearly 150 needs to be changed to New Expensify.

  1. This includes readme and Contributor guidelines.
  2. App Names.
  3. Hard Codes Strings in the App.
  4. Adding new URL new.expensify.com to multiple locations. Such as deep-linking.

Do you want to change all of that or just the APP names?

I can update the IOS app name via xcode. Electron Desktop App name from Code. Android App from Stringx.xml etc.

@Jag96
Copy link
Contributor

Jag96 commented Jul 27, 2021

@parasharrajat Good eye, I think we'd like to update all of those values as you mentioned, for example here's the last PR we used for renaming this: #975.

Job has been posted!

@Jag96 Jag96 added the Exported label Jul 27, 2021
@MelvinBot MelvinBot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 27, 2021
@arpitdeveloper
Copy link

We can change the IOS app name in Display Name in Project target (General Tab) in xcode
The Andriod app name change from app.json and android/app/src/main/res/values/strings.xml
Web title change in web/index.html
desktop title change in mainWindow desktop/main.js

@mananjadhav
Copy link
Collaborator

Proposal

My approach would be to use a Grunt script that will internally update the values for the AppName. For example, I've used react-native-rename earlier which ensures that the Xcode and Android files are updated properly.

In addition to this, we can then pull this value from a config/lang file to enable a quick single command update. This will ease out the process in the future.

@tgolen
Copy link
Contributor

tgolen commented Jul 28, 2021

Heads up, I am already making some of these changes in #4091. Mostly for copy that is shown to users.

@Jag96
Copy link
Contributor

Jag96 commented Jul 28, 2021

@parasharrajat your proposal looks good, I've invited you to the Upwork job, if you're interested in this one I'll assign you once accepted.

@Jag96 Jag96 added Weekly KSv2 and removed Help Wanted Apply this label when an issue is open to proposals by contributors Daily KSv2 labels Jul 29, 2021
@MelvinBot
Copy link

@Jag96, @parasharrajat it looks like no one is assigned to work on this job.
Please double the price or add a comment stating why the job isn't being doubled.

@Jag96
Copy link
Contributor

Jag96 commented Aug 6, 2021

Clearing overdue label, PR is in progress

@MelvinBot MelvinBot removed the Overdue label Aug 6, 2021
@Jag96 Jag96 added the Reviewing Has a PR in review label Aug 9, 2021
@Jag96
Copy link
Contributor

Jag96 commented Aug 12, 2021

Reopening to keep track of payment

@Jag96 Jag96 reopened this Aug 12, 2021
@Jag96 Jag96 changed the title Change site and app titles to New Expensify [HOLD for payment + Bonus Aug 18] Change site and app titles to New Expensify Aug 12, 2021
@Jag96
Copy link
Contributor

Jag96 commented Aug 18, 2021

Paid + bonus

@Jag96 Jag96 closed this as completed Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants