Any whitespace should be trimmed from these places to avoid bugs

[aman-atg]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Places where extra whitespace is causing trouble :-

Search Page

1. search for an email
2. add extra space
3. result will disappear

Profile Page

1. Go to profile Page
2. Edit Firstname and Lastname
3. Add extra space
4. Save
5. Input will be saved as it is. (without trimming the space)

Emoji Picker

1. Login to E.cash
2. Open any chat
3. Click the emoji picker
4. Search for an emoji and add whitespace before or after the search term (Eg. thinking )

Expected Result:

Actual Result:

Workaround:

Remove whitespace manually

Platform:

Where is this issue occurring?

Web ✔️
iOS ✔️
Android ✔️
Desktop App ✔️
Mobile Web ✔️

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @trjExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[aman-atg]

Proposal :

Inside, src/pages/home/report/EmojiPickerMenu/index.js on line 277

the line :- const normalizedSearchTerm = searchTerm.toLowerCase(); can be changed to
const normalizedSearchTerm = searchTerm.toLowerCase().trim();
which will take care of all the whitespaces.

[aman-atg]

This proposal can fix #4156 as well

[rushatgabhane]

@aman-atg I think it'll be a good idea do an audit, and fix it in a combined issue.

[aman-atg]

@rushatgabhane Agreed, I'll see where else this issue is occurring and update #4155.

[aman-atg]

Updated Proposal :

For Search Page

App/src/pages/SearchPage.js

Line 131 in 683bcf4

this.state.searchValue,

• should be changed to

  this.state.searchValue.trim(),

For Profile Page

App/src/pages/settings/Profile/ProfilePage.js

Lines 196 to 197 in 683bcf4

	const isButtonDisabled = (this.props.myPersonalDetails.firstName === this.state.firstName)
	&& (this.props.myPersonalDetails.lastName === this.state.lastName)

• We can prevent this problem from occurring if isButtonDisabled remains false when only whitespaces are added to either name
• So, it should be changed into

         const isButtonDisabled = (this.props.myPersonalDetails.firstName === this.state.firstName.trim())
         && (this.props.myPersonalDetails.lastName === this.state.lastName.trim())  

Finally for Emoji Picker

App/src/pages/home/report/EmojiPickerMenu/index.js

Line 277 in 683bcf4

const normalizedSearchTerm = searchTerm.toLowerCase();

• change this to

        const normalizedSearchTerm = searchTerm.toLowerCase().trim();

[MelvinBot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[trjExpensify]

I like the idea of an audit and combined issue to clean this up! Assigning to Engineering for review. 👍

[johnmlee101]

Yeah seems like .trim() will be needed in a lot of places! @aman-atg feel free to take this over!

[MelvinBot]

Triggered auto assignment to @marklouisdeshaun (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[marklouisdeshaun]

Upwork job post

cc: @aman-atg

[shanto-datta]

Proposal:
To me, trimming the input with .trim() felt right. Or else I would like to use reg expressions to remove white spaces from the input.

[aman-atg]

Hi @marklouisdeshaun, I've submitted the proposal on upwork.

[MelvinBot]

@johnmlee101, @aman-atg, @marklouisdeshaun Whoops! This issue is 2 days overdue. Let's get this updated quick!

[johnmlee101]

Just merged the PR

[marklouisdeshaun]

Not overdue

[marklouisdeshaun]

PR merged

[marklouisdeshaun]

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.