[HOLD for payment 2024-05-06] [$125] Sending image with message has ' appears as HTML for temporarily until the image appears fully

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713478343633609

Action Performed:

1. Open any chat
2. Write a message like "It's breaking" with apostrophe
3. Paste an image and send the image

Expected Result:

Text is sent without any weirdness

Actual Result:

Message appears as it's breaking

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2995.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0192ead78ec42f211a
• Upwork Job ID: 1782467123537166336
• Last Price Increase: 2024-04-22
• Automatic offers:
• rojiphil | Reviewer | 0
• ShridharGoel | Contributor | 0

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[amyevans]

Reproducible in production?: y

I don't think this is accurate, I cannot repro in prod.

Since the message gets corrected by the server I'd consider it a minor issue and not something that needs to block deploy.

That said, I believe all that's needed to fix the bug is updating this line

App/src/libs/ReportUtils.ts

Line 3206 in 09ad468

textForNewComment = `${commentText}\n${CONST.ATTACHMENT_UPLOADING_MESSAGE_HTML}`;

to

textForNewComment = `${parser.htmlToText(commentText)}\n${CONST.ATTACHMENT_UPLOADING_MESSAGE_HTML}`;

@tgolen do you want to take this one as polish to your feature?

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text + attachment shows ' as '.

What is the root cause of that problem?

In the below line, commentText is being used directly without parsing it.

App/src/libs/ReportUtils.ts

Line 3206 in 09ad468

textForNewComment = `${commentText}\n${CONST.ATTACHMENT_UPLOADING_MESSAGE_HTML}`;

What changes do you think we should make in order to solve the problem?

Change that line to this:

textForNewComment = parser.htmlToText(htmlForNewComment);

[tgolen]

I believe @ShridharGoel's proposal is probably the right fix for this. It might need to be ${parser.htmlToText(htmlForNewComment)}\n${CONST.ATTACHMENT_UPLOADING_MESSAGE_HTML}`;

[amyevans]

Alright, the fix is certainly straightforward and agreed upon, therefore I'm going to post the price as $125 and let an open source contributor post the PR.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0192ead78ec42f211a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[amyevans]

@rojiphil mind verifying the existing proposal so that we can get this cranked out? Thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Change HTML to text in comment when uploading attachment #40783

If no regressions arise, payment will be issued on 2024-05-06. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment automatic offer (Reviewer)
• @ShridharGoel requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rojiphil] The PR that introduced the bug has been identified. Link to the PR:
• [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rojiphil] Determine if we should create a regression test for this bug.
• [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[sakluger]

@greg-schroeder can you handle payment on Monday since I'll be OOO? Here are the Upwork offer links.

[melvin-bot]

@rojiphil, @sakluger, @amyevans, @greg-schroeder, @ShridharGoel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[greg-schroeder]

Taking care of payments

[greg-schroeder]

@ShridharGoel you have to accept the offer in Upwork before we can pay you, FYI!

[greg-schroeder]

@rojiphil can you take care of the checklist above?

[sakluger]

Thanks Greg! Taking back over.

Just waiting for @ShridharGoel to accept the Upwork offer and @rojiphil to complete the BZ Checklist before we can close the issue.

[rojiphil]

• [@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR
• [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment
• [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
• [@rojiphil] Determine if we should create a regression test for this bug. : I don’t think this is required
• [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[rojiphil]

and @rojiphil to complete the BZ Checklist

@sakluger BZ Checklist is completed.

[sakluger]

Thanks! I paid @ShridharGoel so we're all good here.