[HOLD for payment 2024-06-13] [$250] IOU - RBR is present in LHN but no error msg in combined report when deleting paid IOU offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4476117
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User A and have no unsettled IOU.

1. Go to staging.new.expensify.com
2. [User A] Request money from User B.
3. [User A] Go offline.
4. [User B] Pay the request.
5. [User A] Delete the request while offline.
6. [User A] Go online.
7. [User A] Go to transaction thread (one report view).

Expected Result:

The error "Unexpected error deleting the money request, please try again later" should be present in one transaction report view.

Actual Result:

There is RBR for one transaction report in LHN, but there is no error in the report itself.
This issue happens when there is only one request.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6438412_1712261176833.20240405_035838.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ebfa7c151ee18ff6
• Upwork Job ID: 1776224622646538240
• Last Price Increase: 2024-04-12
• Automatic offers:
• abdulrahuman5196 | Reviewer | 0

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@alexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

bandicam.2024-04-05.11-47-52-412.mp4

[mountiny]

This is a specific and rare flow so I dont think we have to hold the deploy on this one.

This is related to the combined view cc @NikkiWines

I think we can make this external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ebfa7c151ee18ff6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[kaushiktd]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - RBR is present in LHN but no error msg in combined report when deleting paid IOU offline.

What is the root cause of that problem?

When a receipt error occurs, it will be logged within the parentReportAction of the transaction. Consequently, it will only be visible in the IOU report and not in the money request view.

With the recent introduction of the single transaction view, in scenarios involving only one money request, there won't be an IOU report generated. Therefore, any receipt errors and prompts to download associated files will not be displayed.

What changes do you think we should make in order to solve the problem?

Add Below mention code here

let errors = transaction?.errors ?? {};
if (parentReportAction?.errors) {
    errors = {
        ...errors,
        ...parentReportAction?.errors
    }
}

To get the receipt error from the parentReportAction, we'll add to current error list to show here. As well as, Add condition (showMapAsImage || hasReceipt) || errors inside OfflineWithFeedback component to show or hide image component for expense image.

{(showMapAsImage || hasReceipt) || errors && (

and replace line# 266 with below code:

errors={errors}

Video:

https://drive.google.com/file/d/1L8UHfYOTKoEBsSxGtQ_aZSGoFZ4mS5wy/view?usp=sharing

[alexpensify]

@abdulrahuman5196 when you get a chance, can you review the proposals here? Thanks!

[abdulrahuman5196]

Hi, Will check on the proposals today

[kaushiktd]

@abdulrahuman5196 PR submitted

[alexpensify]

Weekly Update: The PR is moving along through the review process.

[alexpensify]

Weekly Update: The PR is going through a recent round of reviews.

[alexpensify]

Weekly Update: The PR is under the last reviews

[alexpensify]

Heads up, I will be offline until Tuesday, May 28, 2024, and will not actively watch over this GitHub during that period.

If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

[alexpensify]

@madmax330 we need a review in this PR: #40460 (comment)

@abdulrahuman5196 - I'm going to lean on engineering feedback here.

Thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• IOU - RBR is present in LHN with transaction thread #40460

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @kaushiktd requires payment (Needs manual offer from BZ)
• @abdulrahuman5196 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

@kaushiktd - you didn't get an offer since the automation failed here: #39689 (comment)

I'll need to manually create a new request in Upwork before the payment due date. When it's ready, I'll reply here.

[kaushiktd]

Thank you @alexpensify. Earlier I was able to receive an offer on my Upwork from Melvin but it stopped for the last couple of months. Do you have any idea what can be an issue?

[alexpensify]

I don't know about a couple of months ago, the issue that I'm describing today is a recent one. Either way, it's on my radar and I'll deal with it manually. I'll have an update early next week because the payment date is 2024-06-13.

[alexpensify]

Ok, ready for the payment process in Upwork. @kaushiktd - I've created a new Upwork job, please accept here:

https://www.upwork.com/jobs/~01bce135ee5dd897fc

Thanks!

[kaushiktd]

Offer accepted on Upwork @alexpensify

[alexpensify]

Paid via Upwork!

Payouts due: 2024-06-13

• Contributor: $250 @kaushiktd
• Contributor+: $250 @abdulrahuman5196

Upwork job is here