Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mentions v2] Add new rule in ExpensiMarks for room mentions #39538

Closed
rlinoz opened this issue Apr 3, 2024 · 3 comments
Closed

[Mentions v2] Add new rule in ExpensiMarks for room mentions #39538

rlinoz opened this issue Apr 3, 2024 · 3 comments
Assignees
Labels
Engineering NewFeature Something to build that is a new item. Weekly KSv2

Comments

@rlinoz
Copy link
Contributor

rlinoz commented Apr 3, 2024

Room mentions need a new html tag to work, which will be <mention-report>, we need to update our ExpensiMarks rules to find room mentions and replace them with the new tag.

Things to keep in mind:

  • A message can have more than 1 room mention
  • Room names consist of text connected with one or more hyphens and no spaces at all

Details and regex can be found here in the Mentions v2 design doc.

Copy link

melvin-bot bot commented Apr 3, 2024

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 3, 2024
Copy link

melvin-bot bot commented Apr 3, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@robertKozik
Copy link
Contributor

Hi! Please assign me to this one - PR will be ready EOD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants