[HOLD for payment 2024-04-15] [$125] Change the order of items in the global create

[thienlnam]

https://expensify.slack.com/archives/C066HJM2CAZ/p1711236684276869

Currently:

Should be:
Start chat
Track expense
Request money (soon to be Submit expense)
Send money (soon to be Pay someone)
Assign task

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01935b1cfdaa846be8
• Upwork Job ID: 1773048936208711680
• Last Price Increase: 2024-03-27
• Automatic offers:
• akinwale | Reviewer | 0
• ShridharGoel | Contributor | 0

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Change the order of items in the global create.

What is the root cause of that problem?

New change.

This is the order currently:

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Lines 160 to 233 in a5189c4

	menuItems={[
	{
	icon: Expensicons.ChatBubble,
	text: translate('sidebarScreen.fabNewChat'),
	onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.NEW)),
	},
	{
	icon: Expensicons.MoneyCircle,
	text: translate('iou.requestMoney'),
	onSelected: () =>
	interceptAnonymousUser(() =>
	IOU.startMoneyRequest(
	CONST.IOU.TYPE.REQUEST,
	// When starting to create a money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
	// for all of the routes in the creation flow.
	ReportUtils.generateReportID(),
	),
	),
	},
	{
	icon: Expensicons.Send,
	text: translate('iou.sendMoney'),
	onSelected: () =>
	interceptAnonymousUser(() =>
	IOU.startMoneyRequest(
	CONST.IOU.TYPE.SEND,
	// When starting to create a send money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
	// for all of the routes in the creation flow.
	ReportUtils.generateReportID(),
	),
	),
	},
	...(canUseTrackExpense
	? [
	{
	icon: Expensicons.DocumentPlus,
	text: translate('iou.trackExpense'),
	onSelected: () =>
	interceptAnonymousUser(() =>
	IOU.startMoneyRequest(
	CONST.IOU.TYPE.TRACK_EXPENSE,
	// When starting to create a track expense from the global FAB, we need to retrieve selfDM reportID.
	// If it doesn't exist, we generate a random optimistic reportID and use it for all of the routes in the creation flow.
	ReportUtils.findSelfDMReportID() || ReportUtils.generateReportID(),
	),
	),
	},
	]
	: []),
	{
	icon: Expensicons.Task,
	text: translate('newTaskPage.assignTask'),
	onSelected: () => interceptAnonymousUser(() => Task.clearOutTaskInfoAndNavigate()),
	},
	{
	icon: Expensicons.Heart,
	text: translate('sidebarScreen.saveTheWorld'),
	onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.TEACHERS_UNITE)),
	},
	...(!props.isLoading && !Policy.hasActiveChatEnabledPolicies(props.allPolicies)
	? [
	{
	displayInDefaultIconColor: true,
	contentFit: 'contain',
	icon: Expensicons.NewWorkspace,
	iconWidth: 46,
	iconHeight: 40,
	text: translate('workspace.new.newWorkspace'),
	description: translate('workspace.new.getTheExpensifyCardAndMore'),
	onSelected: () => interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt()),
	},
	]
	: []),
	]}

What changes do you think we should make in order to solve the problem?

We can change it to this:

menuItems={[
  {
      icon: Expensicons.ChatBubble,
      text: translate('sidebarScreen.fabNewChat'),
      onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.NEW)),
  },
  ...(canUseTrackExpense
      ? [
          {
              icon: Expensicons.DocumentPlus,
              text: translate('iou.trackExpense'),
              onSelected: () =>
                  interceptAnonymousUser(() =>
                      IOU.startMoneyRequest(
                          CONST.IOU.TYPE.TRACK_EXPENSE,
                          // When starting to create a track expense from the global FAB, we need to retrieve selfDM reportID.
                          // If it doesn't exist, we generate a random optimistic reportID and use it for all of the routes in the creation flow.
                          ReportUtils.findSelfDMReportID() || ReportUtils.generateReportID(),
                      ),
                  ),
          },
      ]
      : []),
  {
      icon: Expensicons.MoneyCircle,
      text: translate('iou.requestMoney'),
      onSelected: () =>
          interceptAnonymousUser(() =>
              IOU.startMoneyRequest(
                  CONST.IOU.TYPE.REQUEST,
                  // When starting to create a money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
                  // for all of the routes in the creation flow.
                  ReportUtils.generateReportID(),
              ),
          ),
  },
  {
      icon: Expensicons.Send,
      text: translate('iou.sendMoney'),
      onSelected: () =>
          interceptAnonymousUser(() =>
              IOU.startMoneyRequest(
                  CONST.IOU.TYPE.SEND,
                  // When starting to create a send money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
                  // for all of the routes in the creation flow.
                  ReportUtils.generateReportID(),
              ),
          ),
  },
  {
      icon: Expensicons.Task,
      text: translate('newTaskPage.assignTask'),
      onSelected: () => interceptAnonymousUser(() => Task.clearOutTaskInfoAndNavigate()),
  },
  {
      icon: Expensicons.Heart,
      text: translate('sidebarScreen.saveTheWorld'),
      onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.TEACHERS_UNITE)),
  },
  ...(!props.isLoading && !Policy.hasActiveChatEnabledPolicies(props.allPolicies)
      ? [
            {
                displayInDefaultIconColor: true,
                contentFit: 'contain',
                icon: Expensicons.NewWorkspace,
                iconWidth: 46,
                iconHeight: 40,
                text: translate('workspace.new.newWorkspace'),
                description: translate('workspace.new.getTheExpensifyCardAndMore'),
                onSelected: () => interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt()),
            },
        ]
      : []),
]}

[habasefa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Changing the the order to the new order of items in the global create

What is the root cause of that problem?

New order of items in the global create

The current ordering is like this:

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Lines 160 to 233 in a5189c4

	menuItems={[
	{
	icon: Expensicons.ChatBubble,
	text: translate('sidebarScreen.fabNewChat'),
	onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.NEW)),
	},
	{
	icon: Expensicons.MoneyCircle,
	text: translate('iou.requestMoney'),
	onSelected: () =>
	interceptAnonymousUser(() =>
	IOU.startMoneyRequest(
	CONST.IOU.TYPE.REQUEST,
	// When starting to create a money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
	// for all of the routes in the creation flow.
	ReportUtils.generateReportID(),
	),
	),
	},
	{
	icon: Expensicons.Send,
	text: translate('iou.sendMoney'),
	onSelected: () =>
	interceptAnonymousUser(() =>
	IOU.startMoneyRequest(
	CONST.IOU.TYPE.SEND,
	// When starting to create a send money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
	// for all of the routes in the creation flow.
	ReportUtils.generateReportID(),
	),
	),
	},
	...(canUseTrackExpense
	? [
	{
	icon: Expensicons.DocumentPlus,
	text: translate('iou.trackExpense'),
	onSelected: () =>
	interceptAnonymousUser(() =>
	IOU.startMoneyRequest(
	CONST.IOU.TYPE.TRACK_EXPENSE,
	// When starting to create a track expense from the global FAB, we need to retrieve selfDM reportID.
	// If it doesn't exist, we generate a random optimistic reportID and use it for all of the routes in the creation flow.
	ReportUtils.findSelfDMReportID() || ReportUtils.generateReportID(),
	),
	),
	},
	]
	: []),
	{
	icon: Expensicons.Task,
	text: translate('newTaskPage.assignTask'),
	onSelected: () => interceptAnonymousUser(() => Task.clearOutTaskInfoAndNavigate()),
	},
	{
	icon: Expensicons.Heart,
	text: translate('sidebarScreen.saveTheWorld'),
	onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.TEACHERS_UNITE)),
	},
	...(!props.isLoading && !Policy.hasActiveChatEnabledPolicies(props.allPolicies)
	? [
	{
	displayInDefaultIconColor: true,
	contentFit: 'contain',
	icon: Expensicons.NewWorkspace,
	iconWidth: 46,
	iconHeight: 40,
	text: translate('workspace.new.newWorkspace'),
	description: translate('workspace.new.getTheExpensifyCardAndMore'),
	onSelected: () => interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt()),
	},
	]
	: []),
	]}

What changes do you think we should make in order to solve the problem?

We have to change the ordering on FloatingActionButtonAndPopover.js (If Save the world is intentionally left from the list)

menuItems={[

{
icon: Expensicons.ChatBubble,
text: translate('sidebarScreen.fabNewChat'),
onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.NEW)),
},
...(canUseTrackExpense
? [
{
icon: Expensicons.DocumentPlus,
text: translate('iou.trackExpense'),
onSelected: () =>
interceptAnonymousUser(() =>
IOU.startMoneyRequest(
CONST.IOU.TYPE.TRACK_EXPENSE,
// When starting to create a track expense from the global FAB, we need to retrieve selfDM reportID.
// If it doesn't exist, we generate a random optimistic reportID and use it for all of the routes in the creation flow.
ReportUtils.findSelfDMReportID() || ReportUtils.generateReportID(),
),
),
},
]
: []),
{
icon: Expensicons.MoneyCircle,
text: translate('iou.requestMoney'),
onSelected: () =>
interceptAnonymousUser(() =>
IOU.startMoneyRequest(
CONST.IOU.TYPE.REQUEST,
// When starting to create a money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
// for all of the routes in the creation flow.
ReportUtils.generateReportID(),
),
),
},
{
icon: Expensicons.Send,
text: translate('iou.sendMoney'),
onSelected: () =>
interceptAnonymousUser(() =>
IOU.startMoneyRequest(
CONST.IOU.TYPE.SEND,
// When starting to create a send money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
// for all of the routes in the creation flow.
ReportUtils.generateReportID(),
),
),
},
{
icon: Expensicons.Task,
text: translate('newTaskPage.assignTask'),
onSelected: () => interceptAnonymousUser(() => Task.clearOutTaskInfoAndNavigate()),
},
...(!props.isLoading && !Policy.hasActiveChatEnabledPolicies(props.allPolicies)
? [
{
displayInDefaultIconColor: true,
contentFit: 'contain',
icon: Expensicons.NewWorkspace,
iconWidth: 46,
iconHeight: 40,
text: translate('workspace.new.newWorkspace'),
description: translate('workspace.new.getTheExpensifyCardAndMore'),
onSelected: () => interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt()),
},
]
: []),
]}

What alternative solutions did you explore? (Optional)

[ShridharGoel]

@thienlnam Can this be made external? We can keep the bounty minimal since the change is small.

[thienlnam]

Yup, was confirming this change but going to make external now

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01935b1cfdaa846be8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

Upwork job price has been updated to $125

[ShridharGoel]

@thienlnam We still want to keep "Save the world" option, right?

[thienlnam]

Yeah, that will be removed at a future date

[akinwale]

This is pretty straightforward. We can move forward with @ShridharGoel's proposal.

🎀👀🎀 C+ reviewed.

[melvin-bot]

Current assignee @thienlnam is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @ShridharGoel 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Change the order of items in global create menu #39204

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment automatic offer (Reviewer)
• @ShridharGoel requires payment automatic offer (Contributor)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @isabelastisser you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[isabelastisser]

All set in Upwork. Closing!

[ShridharGoel]

@isabelastisser I've accepted the offer.