[$500] Chat – New message button appears when create IOU

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4444284
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Navigate to account with a long conversation history
4. Send a message
5. Create IOU

Expected Result:

New message button not appears on the top of the page when create IOU

Actual Result:

New message button appears on the top of the page when create IOU

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423672_1711138394644.IOU.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0133b550ad31059d52
• Upwork Job ID: 1772371228780400640
• Last Price Increase: 2024-04-01

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to vip-vsp

[melvin-bot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[gijoe0295]

Same RCA as #38830. sortedVisibleReportActions contains only visible actions while sortedReportActions contains invisible as well. For hasNewestReportAction check below, we should use the visible one:

App/src/pages/home/report/ReportActionsList.tsx

Line 191 in 665a8ad

const hasNewestReportAction = sortedReportActions?.[0].created === report.lastVisibleActionCreated;

[gijoe0295]

Investigate more and I'm not sure we can consolidate this with #38830. My RCA above is correct but I found no solution yet because I think using sortedReportActions is on purpose. Let's treat this separately.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Pujan92]

I am not sure but RequestMoney API onyx response for the report seems sending old time for lastVisibleActionCreated which could be the issue in below check.

App/src/pages/home/report/ReportActionsList.tsx

Line 191 in 665a8ad

const hasNewestReportAction = sortedReportActions?.[0].created === report.lastVisibleActionCreated;

Screen.Recording.2024-03-23.at.16.37.45.mov

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[yuwenmemon]

Unable to reproduce on the latest main

[yuwenmemon]

I can see this on staging with a different chat though...

[yuwenmemon]

However, the New Message button is dissapearing after about 1 second or so - I can reproduce this pretty consistently so I'm not going to let this block the deploy and rather make this an External Daily Issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0133b550ad31059d52

[melvin-bot]

📣 @cleverjam You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[cleverjam]

I should have a PR ready before the end of the week

[melvin-bot]

This issue has not been updated in over 15 days. @puneetlath, @yuwenmemon, @cleverjam, @rushatgabhane eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[puneetlath]

@cleverjam @rushatgabhane what happened with this? Did a PR get opened?

[cleverjam]

@puneetlath The PR was created: #39665

There is some discrepancy I been discussing with @rushatgabhane in the PR, we think there might be some BE changes needed.

[puneetlath]

Ok got it. It looks like @yuwenmemon is waiting on a response from y'all in the PR on what back-end changes you think you need.

[melvin-bot]

@puneetlath, @yuwenmemon, @cleverjam, @rushatgabhane, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[lanitochka17]

Issue is still reproducible on the latest build 9.0.15-5

Screenrecorder-2024-08-01-13-00-21-657.mp4

[cleverjam]

I still have PR #39665 open but it has been so long I am not sure if I should close it and let someone else take a stab at this...

Edit: since early April.

[puneetlath]

@yuwenmemon what are your thoughts on how to move forward?

[yuwenmemon]

Yeah this might be a more internal issue based on that PR. So let's close that PR and then switch this over to internal.

[puneetlath]

@yuwenmemon given that we closed #vip-split and aren't focused on the IOU flow right now, I think we should just close this out for now. What do you think?

[yuwenmemon]

Yeah sounds good