[HOLD for payment 2024-04-15] [$250] [SelectionList refactor] [Wave Collect] Extract checkbox design and placing outside the BaseListItem component to specific list item components.

[burczu]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Coming from this issue: #35717 and discussed it on Slack.

We recently refactored the SelectionList component extracting list item components like UserListItem, RadioListItem and TableListItem and asking the parent component to decide which list item component should be used by the SelectionList. There is also a BaseListItem component used by all of these newly extracted item components that holds some common part of the code.

Unfortunately this component still encapsulate how the checkbox used in the list item looks like and where it's placed, so the goal of this issue is to extract defining checkbox outside the BaseListItem and move this responsibility to specific list item components.

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

Break down in numbered steps

Expected Result:

Describe what you think should've happened

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e7cfec47d64461f0
• Upwork Job ID: 1767895235204546560
• Last Price Increase: 2024-03-13
• Automatic offers:
• DylanDylann | Contributor | 0
• shubham1206agra | Contributor | 0

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e7cfec47d64461f0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[melvin-bot]

Upwork job price has been updated to $250

[burczu]

Just to inform: I'll be able to start working on this once I've fished my other assignments in the Simplified collect project - most likely this Friday or Monday next week.

[mkhutornyi]

@abzokhattab if you haven't seen already, there's already assignee and not open for proposals. Help Wanted label was also removed.

[abzokhattab]

didnt notice it thanks @mkhutornyi !!

[mountiny]

@shubham1206agra since @burczu is already working on some other wave collect task today and on Friday, would you fancy handling this task too given you have context?

[shubham1206agra]

I will start on it today and finish by today only.

[trjExpensify]

👋 @burczu looks like there's a question for you here: #38448 (comment)

[burczu]

@trjExpensify Ahh, sorry - I've missed that. Answered.

[trjExpensify]

Thanks!

[mkhutornyi]

I am currently sick and have low capacity. Please reassign C+

[DylanDylann]

I can take over as C+

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactored selection list items #38448

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @DylanDylann requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@DylanDylann] Determine if we should create a regression test for this bug.
• [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[shubham1206agra]

Please assign me here as PR author.

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

$250 to both @shubham1206agra and @DylanDylann

[Christinadobrzyn]

Prepping payouts.

• Contributor+: $250 @shubham1206agra (Upwork offer - https://www.upwork.com/ab/applicants/1767895235204546560/offers)
• Contributor+: $250 @DylanDylann (Paid in Upwork - https://www.upwork.com/nx/wm/workroom/36842418/overview)

Upwork job is here.

@shubham1206agra please accept the above offer in Upwork, thanks!

[Christinadobrzyn]

Paid @DylanDylann based on this payment summary - #38222 (comment)

Waiting for @shubham1206agra to accept the Upwork offer

@DylanDylann do we need a regression test?

[DylanDylann]

@Christinadobrzyn I don't think we need a regression test for this issue because this is a refactor task

[Christinadobrzyn]

DM'd @shubham1206agra about the upwork offer

[Christinadobrzyn]

Awesome! Paid this out based on this payment summary - #38222 (comment)

closing - let me know if I missed anything!