[$500] Expense - Old amount is copied to clipboard when the request amount is changed

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.43-3
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to workspace chat.
3. Create a manual request.
4. Go to the request details page.
5. Change the amount and save it.
6. Return to expense report.
7. Right click on the preview > Copy to clipboard.
8. Paste the content.

Expected Result:

The new amount is copied.

Actual Result:

The old amount is copied.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385702_1708434078212.bandicam_2024-02-20_16-17-50-524.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015fa30e8940937ece
• Upwork Job ID: 1759966128870391808
• Last Price Increase: 2024-02-20

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015fa30e8940937ece

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

[hoangzinh]

Looks like a regression from #36298

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Old amount is copied to clipboard when the request amount is changed

What is the root cause of that problem?

Regression as stated above

What changes do you think we should make in order to solve the problem?

1. Define new variable const isIOUTransactionAction = originalMessage?.IOUTransactionID
   and replace the check of shouldConsiderScanningReceiptOrPendingRoute with (isIOUTransactionAction || shouldConsiderScanningReceiptOrPendingRoute) in this condition

const isIOUTransactionAction = originalMessage?.IOUTransactionID

if (!isEmptyObject(reportAction) && (isIOUTransactionAction || shouldConsiderScanningReceiptOrPendingRoute ) && reportAction && ReportActionsUtils.isMoneyRequestAction(reportAction)) {

2. Move definition of originalMessage above definition of isIOUTransactionAction

What alternative solutions did you explore? (Optional)

[flodnv]

Working on it in #36917 (comment)

[shahinyan11]

@flodnv this issue was opened before the one you mentioned

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[puneetlath]

Closing since the offending PR was reverted.