Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimbursements - Focus (cursor) is not appearing in amount input field #36435

Closed
6 tasks done
kavimuru opened this issue Feb 13, 2024 · 6 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.41-2
Reproducible in staging?: y
Reproducible in production?: n (this is new feature)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Open workspace settings page
  2. Click on 'Reimbursements'
  3. Click on 'Rate'
  4. Click on 'Rate' again

Expected Result:

cursor should be displayed on amount input filed

Actual Result:

Focus is not applied in amount input field

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6378581_1707855162484.Screen_Recording_2024-02-13_at_9.33.50_at_night.mp4

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 13, 2024
Copy link

melvin-bot bot commented Feb 13, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 13, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 13, 2024

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@marcochavezf
Copy link
Contributor

Looks like the rate field was changed, this is how it looks in production:

Screenshot 2024-02-13 at 5 35 37 p m

so probably this is not a deploy blocker

@marcochavezf
Copy link
Contributor

Yeah, the MenuItem was introduced in this PR and seems there was a long discussion about it in the related GH issue. I think the TR instructions would need to be updated once the BZ list is completed there cc @tgolen @johncschuster

@marcochavezf
Copy link
Contributor

I will close this GH since it's an intended change in the UI, but feel free to re-open it if disagree

@marcochavezf marcochavezf removed the DeployBlockerCash This issue or pull request should block deployment label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants