[$1000] Android- Workspaces - Comma is disabled in the number pad for language Spanish #29533

izarutskaya · 2023-10-13T07:51:35Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR #29070

Version Number: 1.3.83.4

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

Launch Expensify.
Navigate to Settings > Preferences and change the Language to Spanish
Navigate to Settings > Workspaces (Espacio de trabajo) > Reimbursements (Reembolsos) > Track distance (Medir distancia) and click on the push to page item containing the current rate.
Enter any rate with a comma as the decimal separator.

Expected Result:

Comma is not disabled in the number pad for language Spanish

Actual Result:

Comma is disabled in the number pad for language Spanish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Bug6235036_1697145282930.Screen_Recording_20231012_163342_New_Expensify__1_.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0128a0d2f68a80388a
Upwork Job ID: 1712737843170938880
Last Price Increase: 2024-01-11
Automatic offers:

akinwale | Contributor | 27472369

Issue Owner

Current Issue Owner: @johncschuster

melvin-bot · 2023-10-13T07:51:40Z

Job added to Upwork: https://www.upwork.com/jobs/~0128a0d2f68a80388a

melvin-bot · 2023-10-13T07:51:40Z

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-13T07:51:42Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-10-13T07:51:47Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

pradeepmdk · 2023-10-13T08:16:33Z

@izarutskaya, let me know which device you are using. because in one plus I am not able to reproduce looks like this is an issue device-based

in oneplus my keyboard like this

s-alves10 · 2023-10-13T11:31:59Z

I'm not able to reproduce this

kbecciv · 2023-10-13T15:51:29Z

@pradeepmdk Issue is reproducible on Samsung devices ( tested on SG21/13) Thanks

melvin-bot · 2023-10-16T11:56:34Z

@johncschuster, @burczu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

johncschuster · 2023-10-16T20:37:43Z

Pinged Slack for proposals

DaniloVlad · 2023-10-17T09:10:39Z

Unable to recreate the issue locally.
Tried with both Android 13 and 12. Not sure if my environment is set up 100% as I can't access the SO link in the top-level readme which suggests important set up steps for android.

However, here is a video of Android 12.0 working:

commaRepro.mp4

@johncschuster @kbecciv

johncschuster · 2023-10-19T20:34:20Z

Thank you for trying that, @DaniloVlad.

@kbecciv, can you clarify what steps we need to follow to reproduce this? Is this behavior exclusive to Samsung devices?

melvin-bot · 2023-10-20T16:00:16Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot · 2023-10-23T12:30:18Z

@johncschuster, @burczu Whoops! This issue is 2 days overdue. Let's get this updated quick!

johncschuster · 2023-10-24T20:35:02Z

@kbecciv bump! Can you please clarify the reproduction steps? Is this specific to Samsung devices?

johncschuster · 2023-10-26T19:05:37Z

@kbecciv bump!

kbecciv · 2023-10-26T21:25:29Z

Yes, this is issue reproducible on Sumsung devices, confirmed with 2 testers.

shubham1206agra · 2024-02-26T15:06:36Z

@johncschuster Can you start payment process here?

akinwale · 2024-02-28T05:46:32Z

Looks like automation missed this. The PR was deployed to production on 2022-02-15, so the payment due date is 2022-02-22.

cc @johncschuster

akinwale · 2024-03-04T12:30:25Z

@johncschuster bump.

johncschuster · 2024-03-07T20:04:48Z

Sorry for missing this! I'll get this taken care of now.

johncschuster · 2024-03-07T20:09:05Z

I've extended invites to this job to both @akinwale and @shubham1206agra, can you please accept that so I can issue payment? Thank you!

Milos213 · 2024-03-07T20:09:09Z

There was regression #36436

shubham1206agra · 2024-03-08T02:23:09Z

There was regression #36436

This was a minor UI refinement.

shubham1206agra · 2024-03-11T09:46:41Z

@johncschuster Can you hold my payment temporarily as per https://expensify.slack.com/archives/C02NK2DQWUX/p1710150138788529?

johncschuster · 2024-03-18T20:01:44Z

Thanks for everyone's patience! Coming from the Contributing Guidelines, payment will be subject to a regression penalty:

If a PR causes a regression at any point within the regression period (starting when the code is merged and ending 168 hours (that's 7 days) after being deployed to production):

payments will be issued 7 days after all regressions are fixed (ie: deployed to production)
a 50% penalty will be applied to the Contributor and Contributor+ for each regression on an issue

@akinwale, I'm issuing a payment of $500 (50% of $1000) to you now.
@shubham1206agra, can you please ping me when you've gotten your Upwork account issue taken care of? I'll take care of payment after that.

shubham1206agra · 2024-03-19T00:31:29Z

@johncschuster Since this was a very big PR, and the follow up was a minor design change. I will request you to not apply regression penalty here.

johncschuster · 2024-03-20T20:34:21Z

@shubham1206agra I don't see anything in our contributing docs that makes an exception for the regression penalty based on the type of regression. Do you see anything that makes an exception? I'm happy to discuss it with the team, but without a documented exception case, I'm inclined to follow the process and apply the penalty.

shubham1206agra · 2024-03-25T05:25:36Z

@johncschuster In the document https://docs.google.com/document/d/1BvohU05MTaHnjOD_vwJv_aqDAirv-ChkyRnKCAvOVyQ/edit#bookmark=id.qr9c929owwy8, there is a line about exceptions.

Exceptions can be made by the assigned internal engineer for large PRs that introduce new functionality.

And this PR might fall under that cause the PR introduces new flow for Reimbursement Rate.

shubham1206agra · 2024-03-27T11:04:00Z

@johncschuster Bump on the above.

shubham1206agra · 2024-03-27T11:09:52Z

@johncschuster I have discussed this internally. You may close this issue after the above resolution, as I am keeping track of payment internally and will ask to pay once the issue is resolved. Just write in the payment summary that I have not been paid yet.

shubham1206agra · 2024-03-29T07:16:07Z

Bump on this @johncschuster

joekaufmanexpensify · 2024-04-04T20:36:01Z

Got assigned this one. Think it may be same root cause. Curious if others agree?

johncschuster · 2024-04-04T21:23:06Z

Payment Summary

@shubham1206agra - $500 to be paid via Manual Request

shubham1206agra · 2024-04-05T00:57:02Z

@johncschuster You may want to discuss #29533 (comment) too.
cc @tgolen

shubham1206agra · 2024-04-08T05:51:12Z

Bump on the above @johncschuster

shubham1206agra · 2024-04-17T16:25:38Z

@johncschuster Bump on the above, and we can process payment now.

shubham1206agra · 2024-05-08T23:52:19Z

@johncschuster Bump here.

shubham1206agra · 2024-05-13T15:51:40Z

@johncschuster Bump here.

johncschuster · 2024-05-13T20:31:16Z

Hi @shubham1206agra, I'm sorry for the delay here. I was under the impression you would be paid via Manual request. Is that not correct?

Edit: Oh, I'm sorry! I can see here that we were simply waiting on your Upwork profile to be corrected. Can you send me your Upwork profile? Thank you!

shubham1206agra · 2024-05-14T00:40:17Z

@johncschuster Here is my upwork profile https://www.upwork.com/freelancers/~010d05728d5d18affe.

Also, can you discuss #29533 (comment).

johncschuster · 2024-05-14T19:28:18Z

Thanks for posting your Upwork profile, @shubham1206agra! I've extended the offer, here. The comment above has already been discussed, and we're going to stick with our decision.

shubham1206agra · 2024-05-15T00:43:44Z

@johncschuster Accepted

johncschuster · 2024-05-15T13:43:01Z

Payment has been issued! 🎉

izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 13, 2023

melvin-bot bot changed the title ~~Android- Workspaces - Comma is disabled in the number pad for language Spanish~~ [$500] Android- Workspaces - Comma is disabled in the number pad for language Spanish Oct 13, 2023

melvin-bot bot assigned johncschuster Oct 13, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 13, 2023

melvin-bot bot assigned burczu Oct 13, 2023

kavimuru mentioned this issue Oct 13, 2023

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed

97 tasks

melvin-bot bot added the Overdue label Oct 16, 2023

melvin-bot bot removed the Overdue label Oct 16, 2023

melvin-bot bot added the Overdue label Oct 19, 2023

melvin-bot bot removed the Overdue label Oct 19, 2023

melvin-bot bot added the Overdue label Oct 23, 2023

melvin-bot bot removed the Overdue label Oct 24, 2023

johncschuster closed this as completed Apr 4, 2024

strepanier03 reopened this May 8, 2024

johncschuster closed this as completed May 15, 2024

[$1000] Android- Workspaces - Comma is disabled in the number pad for language Spanish #29533

[$1000] Android- Workspaces - Comma is disabled in the number pad for language Spanish #29533

Comments

izarutskaya commented Oct 13, 2023 • edited by tgolen Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Oct 13, 2023

pradeepmdk commented Oct 13, 2023 • edited Loading

s-alves10 commented Oct 13, 2023

kbecciv commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

johncschuster commented Oct 16, 2023

DaniloVlad commented Oct 17, 2023

johncschuster commented Oct 19, 2023

melvin-bot bot commented Oct 20, 2023

melvin-bot bot commented Oct 23, 2023

johncschuster commented Oct 24, 2023

johncschuster commented Oct 26, 2023

kbecciv commented Oct 26, 2023

shubham1206agra commented Feb 26, 2024

akinwale commented Feb 28, 2024

akinwale commented Mar 4, 2024

johncschuster commented Mar 7, 2024

johncschuster commented Mar 7, 2024

Milos213 commented Mar 7, 2024

shubham1206agra commented Mar 8, 2024

shubham1206agra commented Mar 11, 2024

johncschuster commented Mar 18, 2024 • edited Loading

shubham1206agra commented Mar 19, 2024

johncschuster commented Mar 20, 2024

shubham1206agra commented Mar 25, 2024 • edited Loading

shubham1206agra commented Mar 27, 2024

shubham1206agra commented Mar 27, 2024

shubham1206agra commented Mar 29, 2024

joekaufmanexpensify commented Apr 4, 2024

johncschuster commented Apr 4, 2024

Payment Summary

shubham1206agra commented Apr 5, 2024

shubham1206agra commented Apr 8, 2024

shubham1206agra commented Apr 17, 2024

shubham1206agra commented May 8, 2024

shubham1206agra commented May 13, 2024

johncschuster commented May 13, 2024 • edited Loading

shubham1206agra commented May 14, 2024

johncschuster commented May 14, 2024

shubham1206agra commented May 15, 2024

johncschuster commented May 15, 2024

izarutskaya commented Oct 13, 2023 •

edited by tgolen

Loading

pradeepmdk commented Oct 13, 2023 •

edited

Loading

johncschuster commented Mar 18, 2024 •

edited

Loading

shubham1206agra commented Mar 25, 2024 •

edited

Loading

johncschuster commented May 13, 2024 •

edited

Loading