[HOLD for payment 2024-04-29] IOS - Search - Extra padding below Referral banner in Search list

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4-38.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app.
2. Open search list.
3. Focus on the search field.

Expected Result:

There is no extra padding below Referral banner in Search list.

Actual Result:

There is extra padding below Referral banner in Search list.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6370495_1707319131046.RPReplay_Final1707314452.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @johncschuster

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related #vip-vsb
CC @quinthar

[allgandalf]

regression from #35058

Comments also associated with regression: #35058 (review)

[luacmartins]

@lukemorawski are you able to work on a fix for this since your PR introduced this regression?

[luacmartins]

I don't think we need to block deploy on this

[lukemorawski]

@luacmartins no worries, will tackle that!

[melvin-bot]

@luacmartins Huh... This is 4 days overdue. Who can take care of this?

[lukemorawski]

still working on that. It's actually more trickier than it look and I have found more related bugs to it. I'll hopefully drop a fix to it tomorrow.

[melvin-bot]

@luacmartins 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@luacmartins 10 days overdue. Is anyone even seeing these? Hello?

[luacmartins]

We have a draft PR up.

[lukemorawski]

@luacmartins PR is open

[Julesssss]

Assigning @abdulrahuman5196 based on this comment

[lukemorawski]

@luacmartins this was fixed with #38039

[luacmartins]

Updated the issue. We had a regression caused by that PR, could you please take a look?

[garrettmknight]

Same here

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @abdulrahuman5196 paid $(AMOUNT) via Upwork (LINK)
• Contributor: @lukemorawski is from an agency-contributor and not due payment

BugZero Checklist (@johncschuster)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@johncschuster, @luacmartins, @abdulrahuman5196, @lukemorawski Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@johncschuster, @luacmartins, @abdulrahuman5196, @lukemorawski Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@johncschuster, @luacmartins, @abdulrahuman5196, @lukemorawski 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@johncschuster, @luacmartins, @abdulrahuman5196, @lukemorawski Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[johncschuster]

Thanks for your patience, everyone! I've needed to make sense of the payments here since there was a regression and a different C+ reviewer. Here's what I've got:

Contributor: @lukemorawski - to be paid $250 ($500-50% regression deduction)
Contributor+ that reviewed offending PR: @rushatgabhane - to be paid $250 ($500-50% regression deduction)
Contributor+ that reviewed the final PR: @abdulrahuman5196 - $500

@luacmartins do you agree with that assessment?

[johncschuster]

Ok, I was chatting with @luacmartins to unwind some confusion. I had misunderstood this comment and thought the regression came from there.

This was the original PR: #38039
Reviewed by: abdulrahuman5196
Created regression

This is the fix PR: #40912
Reviewed by: mollfpr

With that in mind, here's the updated payment summary:

Contributor: @lukemorawski - to be paid $250 ($500-50% regression deduction) - Part of an agency
Contributor+ that reviewed offending PR: @abdulrahuman5196 - to be paid $250 ($500-50% regression deduction) - Upwork
Contributor+ that reviewed the final PR: @mollfpr - $500 - PAID VIA MANUAL REQUEST

[melvin-bot]

@johncschuster, @luacmartins, @abdulrahuman5196, @lukemorawski Whoops! This issue is 2 days overdue. Let's get this updated quick!

[johncschuster]

I'm working on issuing payment now.

[johncschuster]

@abdulrahuman5196 I've invited you to the job in Upwork here, can you accept that?

@lukemorawski, can you either send me your Upwork profile so I can extend the job, or can you apply to the job using this link? Thanks!

@lukemorawski ignore the above. I just found you in Slack and realized you are from CallStack. No action required! 🎉

@mollfpr, you can go ahead and submit the manual request whenever you're ready.

[johncschuster]

Bumped @abdulrahuman5196 in Slack to accept the offer 👍

[johncschuster]

Payment through Upwork has been issued to @abdulrahuman5196 🎉

@mollfpr - please refer to this comment for your Manual Request.

[JmillsExpensify]

$500 approved for @mollfpr