-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-07] [$500] Chat - Keyboard displayed over compose box when user returned from Distance Request Money #34724
Comments
Job added to Upwork: https://www.upwork.com/jobs/~015a375a0746825e33 |
Triggered auto assignment to @sophiepintoraetz ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Keyboard is opened over compose box when returning from distance request money if delete a stop waypoint What is the root cause of that problem?When deleting a stop waypoint, we open Please take a look at the below code snippet App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js Lines 492 to 500 in c14ca54
As you can see, we focus the composer when modal is invisible and the route is focused if modal is invisible or route is not focused previously. When Note: This issue doesn't happen when not deleting a stop waypoint. Why? What changes do you think we should make in order to solve the problem?I think we should not change the modal visibility while modal is opened
This works as expected Result34724.mp4What alternative solutions did you explore? (Optional)Solution 1 App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js Line 500 in c14ca54
to
Solution 2 |
Reviewing tomorrow! |
Happy with @s-alves10's proposal! We are just unnecessarily setting modal visibility, which causes focus to get called on the composer too early. 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
I think we should hold this for @ntdiary's modal refactor |
Ah thanks for flagging @situchan! Looking at it, that PR looks like it's going to take a while, so I think it's probably worth fixing this in the meantime, happy to defer to your judgement though @jasperhuangg! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @s-alves10 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-07. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Triggered auto assignment to @adelekennedy ( |
Regression Test Proposal
Do we agree 👍 or 👎 |
@jjcoffee, @jasperhuangg, @adelekennedy, @s-alves10 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
regression test makes sense to me - @jasperhuangg for your thoughts as well! |
still not set on regression test steps but issuing payment Payouts due:Contributor: $500 @s-alves10 (Upwork) |
@adelekennedy agree! Thanks @jjcoffee for writing that up. I gave you thumbs |
@jjcoffee, @jasperhuangg, @adelekennedy, @s-alves10 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.26-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Chat should be properly displayed
Actual Result:
Keyboard displayed over compose box when user returned from Distance Request Money
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6346204_1705567130891.RPReplay_Final1705534257.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: