[$500] [HOLD for payment 2023-12-21] IOU - Back button unresponsive on touches on IOU details page in offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.7.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: user should be Signed In

1. Open app
2. Navigate to any 1:1 converssation
3. Make a Money Request
4. Turn you internet connection off
5. Navigate to IOU details page
6. Tap on back button in header

Expected Result:

User should be navigated back on IOU listing page

Actual Result:

The back button unresponsive on touches. It is unable to navigate back and user get stuck on the empty page with loading skeleton animation.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6298261_1701492742604.RPReplay_Final1701483103.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011ceacebec21ea886
• Upwork Job ID: 1730978209177305088
• Last Price Increase: 2023-12-02
• Automatic offers:
• ikevin127 | Contributor | 27990113

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011ceacebec21ea886

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[ikevin127]

Proposal

Please re-state the problem that we are trying to solve in this issue

User should be able to navigate back on IOU listing page but currently the header's back button does not function.

What is the root cause of that problem?

App/src/pages/home/HeaderView.js

Lines 199 to 201 in 1682be4

	{isLoading ? (
	<ReportHeaderSkeletonView />
	) : (

Issue comes from the above code block because in offline mode the isLoading is true and it renders the ReportHeaderSkeletonView component which has onPress={() => {}}.

What changes do you think we should make in order to solve the problem?

Add new prop onBackButtonPress = () => {} (default) to ReportHeaderSkeletonView component and then from HeaderView component pass :

<ReportHeaderSkeletonView onBackButtonPress={props.onNavigationMenuButtonClicked} />

props.onNavigationMenuButtonClicked being the same function used below in the same component for the header go back button when isLoading is false.

What alternative solutions did you explore? (Optional)

Alternatively we can pass Navigation.goBack() directly to ReportHeaderSkeletonView's onPress which would only require changes in the ReportHeaderSkeletonView component.

Videos

iOS: Native

Screen.Recording.2023-12-02.at.20.08.42.mov

[chiItepin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user is not able to navigate back to the previous screen while the screen remains "loading".
As a user I should be able to navigate back at any time without being constrained by either latency or an offline connection.

What is the root cause of that problem?

The ReportHeaderSkeletonView component is rendering a "dummy" back button without an onPress callback. However, Skeleton/Shimmer views should be minimal, it should not be rendering this "dummy" back button.

What changes do you think we should make in order to solve the problem?

Instead of providing the same onNavigationMenuButtonClicked prop its parent use to toggle the menu, I would remove the "dummy" back button rendered by the Skeleton, these views should be minimal and should not rely on props that don't directly contribute to the purpose of the skeleton.

Once the "dummy" back button is removed from the Skeleton, I would make sure the the main back button which in this case is the PressableWithoutFeedback rendered by the HeaderView would be remain rendering regardless of whether the screen is loading or not, it should not care about the status.

Providing this experience to our users:

Benefits:

• Maintain one header back button (expanding the dummy back button would make this piece less maintainable on the other hand)
• Better user experience
• Consistency

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

📣 @chiItepin! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[chiItepin]

Contributor details
Your Expensify account email: hector.almeida.ca@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~011f4f88a011c86571

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[thesahindia]

@ikevin127's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[marcochavezf]

Thanks for the review @thesahindia, the proposal also looks good to me, assigning @ikevin127 🚀

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ikevin127]

@thesahindia PR #32592 ready for review! 🚀

[ikevin127]

I think there's been an issue with melvin not changing the title of the issue to [HOLD for payment {date}] 3 days ago when the fix was deployed to production as per #32592 (comment)

cc @marcochavezf @twisterdotcom

[twisterdotcom]

Ah I see. Okay, this should have been [HOLD for payment 2023-12-21]. @ikevin127 and @thesahindia I will get this paid, but it will have to be post Christmas.

[ikevin127]

cc @twisterdotcom

[twisterdotcom]

Payment Summary:

• @thesahindia to be paid $500 here (Contributor+)
• @ikevin127 to be paid $500 here (Contributor)

[thesahindia]

Requested on New Dot.

[JmillsExpensify]

$500 payment approved for @thesahindia based on comment above.

[melvin-bot]

This issue has not been updated in over 15 days. @marcochavezf, @twisterdotcom, @ikevin127, @thesahindia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[twisterdotcom]

I think we can close this right?