[HOLD for payment 2024-02-14] [$500] Login - When try to log in with Google, an error message under email field appears

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.0-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Click on compose box
3. Click on the Google button to log in.

Expected Result:

No error message should be displayed

Actual Result:

An error message under email field appears saying that you must enter an email or phone number

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• Windows: Chrome /
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6278454_1700099470387.bandicam_2023-11-15_20-18-11-460.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01898b63da3ac78d6c
• Upwork Job ID: 1725561784156704768
• Last Price Increase: 2023-11-24
• Automatic offers:
• aimane-chnaif | Contributor | 27870856
• FitseTLT | Contributor | 28071207

[s-alves10]

#29640 would fix this issue

I mean this PR #30563

[aimane-chnaif]

Not able to reproduce on main

[roryabraham]

Confirmed reproducible on staging but not main

[roryabraham]

Not able to reproduce locally on the staging branch either

[roryabraham]

Not going to treat this as a blocker, and we'll see if it's fixed on staging after the next staging deploy. I don't actually think it will be – #30563 is already on staging.

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01898b63da3ac78d6c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[Mihai-Damaschin]

Contributor details
Expensify account email: isus.hristosovici0000@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01216afb656aa97e1f

Proposal

Please re-state the problem that we are trying to solve in this issue.

When user makes a click on log with google or apple buttons, a validation error appears under the text input

What is the root cause of that problem?

The root of this problem, is the validate function that are called on every onBlur event of the text input, so every time the user make a click above the text input, the validation function is triggered. Validation function works well and throw the right error, cause the input are empty.

What changes do you think we should make in order to solve the problem?

I run the project and checked the issue, the simplest way to solve it is to add new state to the LoginForm component from BaseLoginForm file. New state will be changed to true when user make click on the apple or google log in buttons, and will prevent the validate function from onBlur event of TextInput component.

This way doesn't require to remove any existent code. I already tested this solution.

What alternative solutions did you explore? (Optional)

If to remove the existent code is allowed, i can find another way to fix it.

[melvin-bot]

📣 @Mihai-Damaschin! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Fralalala]

Proposal

• In the onBlur function, if login input is empty, dont validate.

Please re-state the problem that we are trying to solve in this issue.

• When viewing the login page, you are initially focused on the Email Input field. Clicking anything else besides the input field will activate the validation code which shows an error if nothing is inputted or an incorrect email is inputted.

What is the root cause of that problem?

• When a user opens the log in page and the first element they click is a Single Sign On (while there's nothing in the input), it will trigger a blur which will trigger the onBlur function. This would then validate an empty string, giving out the error.

This problem is only occurring on our first blur.

What changes do you think we should make in order to solve the problem?

• We add an additional condition of login === "" in:

  App/src/pages/signin/LoginForm/BaseLoginForm.js

  Lines 255 to 257 in f806a94

  	if (firstBlurred.current) {
  	return;
  	}

This will allow us to validate via onBlur when we only have a valid input.

This also allows users to click in and out of the input repeatedly if there's no input and not show any errors.

This also retains all the form guidelines from
#31413 (comment)
except the third point blur input: validate which only happens once and any validation afterwards are via input changes which is already present in the code base.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix error message display bug on google signin #34863

If no regressions arise, payment will be issued on 2024-02-14. 🎊

For reference, here are some details about the assignees on this issue:

• @FitseTLT requires payment automatic offer (Contributor)
• @aimane-chnaif requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[roryabraham]

@anmurali this is ready for payment.

[anmurali]

@FitseTLT has been paid
@aimane-chnaif offer expired, so sent a new one here
Do we need to add a regression test? If yes, @aimane-chnaif can you propose it?

Adding a backup BZ member to close this off after those two things are handled here as I am OOO

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

@FitseTLT, @roryabraham, @adelekennedy, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[adelekennedy]

@aimane-chnaif paid! Bump on the regression test question

[aimane-chnaif]

We don't need regression test as this was deploy blocker, which means that QA team found this during regression test

[adelekennedy]

perfect - then we can close this!