[HOLD for payment 2023-11-29] [$125] Desktop - Avatars in split preview card too close to right edge

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.99.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1700000146978699

Action Performed:

1. Create a split with two other people
2. Look at the preview card

Expected Result:

Avatar stacak should be 20px (or is it 16px?) away from the right edge of the card, it should match the same padding as left side

Actual Result:

Avatar stack is too close to right edge

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

2023-11-15.1.10.24.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014ce3040ec2425cf6
• Upwork Job ID: 1724853684623753216
• Last Price Increase: 2023-11-15
• Automatic offers:
• paultsimura | Contributor | 27689355

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014ce3040ec2425cf6

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Upwork job price has been updated to $125

[youssef-lr]

I'm going to try and fix this in an ongoing PR. If not we can let this be external.

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The avatars are incorrectly placed

What is the root cause of that problem?

The avatars use the negative margin here, which was added in 2021 (#2112), but now seems like a redundant code:

App/src/styles/styles.ts

Lines 2661 to 2664 in e953a65

	moneyRequestPreviewBoxAvatar: {
	marginRight: -10,
	marginBottom: 0,
	},

What changes do you think we should make in order to solve the problem?

We actually can remove the special style here:

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 312 in c536053

<View style={styles.moneyRequestPreviewBoxAvatar}>

And the moneyRequestPreviewBoxAvatar style altogether.

What alternative solutions did you explore? (Optional)

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The avatars are incorrectly placed

# What is the root cause of that problem?

The avatars margin is -10 .. and in the left we have 16 px so the padding on the right and left are not the same

App/src/styles/styles.ts

Lines 2666 to 2668 in 91979f9

	padding: 16,
	},

App/src/styles/styles.ts

Line 2682 in 91979f9

marginRight: -10,

What changes do you think we should make in order to solve the problem?

we have 16 px in the front padding so we need to make the avatar padding -16 instad of -10

 marginRight: -16, 

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The avatars are incorrectly placed

What is the root cause of that problem?

We have incorrect marginRight in moneyRequestPreviewBoxAvatar

What changes do you think we should make in order to solve the problem?

We need to remove marginRight or smaller than now.

App/src/styles/styles.ts

Line 2683 in cc5a272

marginRight: -10,

What alternative solutions did you explore? (Optional)

[parasharrajat]

@paultsimura 's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[chuckchoiboi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Avatar stack has a hard-coded margin which makes the margin to go beyond the parent container's width.

What is the root cause of that problem?

The Avatar stack has a margin-right of -16.

What changes do you think we should make in order to solve the problem?

It seems like the row with the amount and avatar has flex: 1 1 0% so the row's items (amount/avatar stack) are each at the left-most end and right-most end of the row, but the avatar image doesn't align with the text below due to its border-width of 2px giving the image stack the cool hovering look.

We should adjust this to the margin-right of -3px to make the image content align with the text below.

What alternative solutions did you explore? (Optional)

We should remove margin from moneyRequestPreviewBoxAvatar, but set border-right to 0px for the right most child of the avatar stack. This will make the content align perfectly with the text below.

[melvin-bot]

📣 @parasharrajat Please request via NewDot manual requests for the Reviewer role ($125)

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[paultsimura]

Thanks. The PR is ready: #31430

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.1-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: MultipleAvatars negative margin #31430

If no regressions arise, payment will be issued on 2023-11-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment offer (Contributor)
• @parasharrajat does not require payment (Eligible for Manual Requests)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Hard to determine as UI was changed many times and it is difficult to say where the style went wrong.
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Nope. I think we should check style in each PR.
• [@parasharrajat] Determine if we should create a regression test for this bug. Not. Required. It is a style issue.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[puneetlath]

Payment summary:

• C - @paultsimura - $125 - paid via Upwork
• C+ - @parasharrajat - $125 - to be paid via NewDot

Closing. Thanks everyone!

[parasharrajat]

Payment requested as per #31394 (comment)

[JmillsExpensify]

$125 payment approved for @parasharrajat based on comment above.