Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: Expensify.cash 2021-05-19 #3000

Closed
10 tasks done
OSBotify opened this issue May 19, 2021 · 9 comments
Closed
10 tasks done

Deploy Checklist: Expensify.cash 2021-05-19 #3000

OSBotify opened this issue May 19, 2021 · 9 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@roryabraham
Copy link
Contributor

Manually added #2926 to the checklist. It wasn't added because of this seemingly random workflow failure.

@isagoico
Copy link

Starting QA 🚀

@isagoico isagoico added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 19, 2021
@isagoico
Copy link

@isagoico isagoico removed the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 20, 2021
@Julesssss
Copy link
Contributor

I created an issue for #2394. But I am checking it off the list as A) the feature is behind a beta, and B) it will be fixed as part of this PR

@isagoico
Copy link

Starting QA!

@isagoico isagoico added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 20, 2021
@isagoico
Copy link

Regression is finished!
1 issue found today.

  1. Message - Pressing enter over a message shows a black border around it #3041

PRs are finished too.
1 comment added:

  1. Create currency modal with react-native-permissions and geolocation #2194 (comment) - Not sure if deploy blocker since the feature is behind a beta.

Thanks!

@isagoico
Copy link

#2194 (comment) - known behaviour

@isagoico
Copy link

:shipit:

@roryabraham
Copy link
Contributor

Ooo this was issue #3000. Fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants