Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Scan - Chat header is disabled when creating a Scan request with a user with no prior chat #29563

Closed
1 of 6 tasks
lanitochka17 opened this issue Oct 13, 2023 · 36 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 13, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.83-10

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to + > Request money > Scan > Upload a file
  3. Select a user that has no prior chat
  4. Complete the Scan request
  5. Click on the chat header

Expected Result:

User is able to click on the chat header

Actual Result:

User is able to click on the chat header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Windows: Chrome >/summary>
Bug6235726_1697194711536.bandicam_2023-10-13_11-18-54-359.mp4
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c8cfe24e2dd984c7
  • Upwork Job ID: 1715171416379404288
  • Last Price Increase: 2023-11-06
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@s-alves10
Copy link
Contributor

I'm not able to reproduce this issue

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2023
@CortneyOfstad
Copy link
Contributor

I wasn't able to recreate this either — @lanitochka17 can we confirm if the issue is still taking place? Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@CortneyOfstad
Copy link
Contributor

Bump @lanitochka17 ^^^

@CortneyOfstad
Copy link
Contributor

I am heading OoO until Oct. 25, so reassigning BZ to see if they can get this to be recreated, or get confirmation that we can close this 👍

@CortneyOfstad CortneyOfstad removed their assignment Oct 18, 2023
@CortneyOfstad CortneyOfstad added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@CortneyOfstad CortneyOfstad self-assigned this Oct 18, 2023
@mallenexpensify
Copy link
Contributor

Also unable to reproduce via Browserstack, windows, chrome
image

image

Can you please try to reproduce @lanitochka17 ? If you're unable to, will you close plz?

@lanitochka17
Copy link
Author

@mallenexpensify Hello
Issue is still reproduce with Scan and Manual request on :expensify: account

20231019_205450.mp4

On Gmail, initially, the header is disabled, but not after a few seconds

20231019_205700.mp4

@mallenexpensify mallenexpensify added the Internal Requires API changes or must be handled by Expensify staff label Oct 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01c8cfe24e2dd984c7

@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@mallenexpensify
Copy link
Contributor

@rushatgabhane do you have a PC to test with? If so, can you please see if you can reproduce?
I don't have a PC handy. Thx

@rushatgabhane
Copy link
Member

rushatgabhane commented Oct 20, 2023

sorry, i don't have my windows laptop around.

i can't repro this bug on macos chrome however

@mallenexpensify
Copy link
Contributor

Was able to reproduce, was this

initially, the header is disabled, but not after a few seconds

So, at least for my instance, there's just a delay.
@rushatgabhane do you think this can be external?

2023-10-20_15-56-07.mp4

@rushatgabhane
Copy link
Member

@mallenexpensify yes, this can be external

@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

@CortneyOfstad @mallenexpensify @rushatgabhane @lanitochka17 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Oct 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 30, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@CortneyOfstad
Copy link
Contributor

@rushatgabhane any updates here?

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2023
@mallenexpensify mallenexpensify removed their assignment Oct 30, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 2, 2023
@rushatgabhane
Copy link
Member

@DylanDylann after removing disabled, we still can't open the detail page of the optimistic user?

disabled={shouldDisableDetailPage}

Could you please explain what piece of code does that?

@melvin-bot melvin-bot bot removed the Overdue label Nov 3, 2023
Copy link

melvin-bot bot commented Nov 3, 2023

@CortneyOfstad @rushatgabhane @lanitochka17 this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

Copy link

melvin-bot bot commented Nov 6, 2023

@CortneyOfstad, @rushatgabhane, @lanitochka17 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Nov 6, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@CortneyOfstad
Copy link
Contributor

@rushatgabhane @lanitochka17 any updates here? Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2023
@DylanDylann
Copy link
Contributor

@CortneyOfstad Firstly, I think we should confirm what is expected because I see it seems conflict with this PR #23802

@melvin-bot melvin-bot bot added the Overdue label Nov 9, 2023
@CortneyOfstad
Copy link
Contributor

Let me check get some internal eyes on this to confirm @DylanDylann — thanks!

Copy link

melvin-bot bot commented Nov 9, 2023

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@CortneyOfstad
Copy link
Contributor

@tgolen it appears that the "issue" might be expected behavior based on the comment here. Can you confirm? TIA!

@tgolen
Copy link
Contributor

tgolen commented Nov 9, 2023

Yeah, that is how I interpret it as well. Sounds like we can close this as works as expected.

@tgolen tgolen closed this as completed Nov 9, 2023
Copy link

melvin-bot bot commented Nov 9, 2023

@tgolen @CortneyOfstad Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

7 participants