[$500] Sign In - Data - Account and app data is not fully loaded after attempt to Sign In with suspended account

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open https://staging.new.expensify.com/
2. Tap in email label
3. Write a suspended account email
4. Tap "Continue" button
5. Tap on "Back"
6. Replace the email with a valid (non-suspended) account email
7. Tap on "Continue" button
8. Fill the magic code label
9. Observe the listed chat in LHN
10. Tap on FAB
11. Tap on Request Money
12. Select Manual tab
13. Tap on currency
14. Observe listed currencies

Suspended account: applausetester+omc1@applause.expensifail.com
Tested account: applausetester+omw1@applause.expensifail.com

Expected Result:

User should be signed in and all account and app data should be loaded

Actual Result:

Step 9:
Only several conversations listed in LHN (the issue occurs occasionally)
Step 13:
Unable to change currencies because all currencies is missing on search page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.79-3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6227680_1696605830034.RPReplay_Final1696547153.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01240579ed69bf1c9d
• Upwork Job ID: 1711711997061881856
• Last Price Increase: 2023-10-17
• Automatic offers:
• mollfpr | Reviewer | 27463078

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01240579ed69bf1c9d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

@NicMendonca Whoops! This issue is 2 days overdue. Let's get this updated quick!

[NicMendonca]

^ just added external label

[NicMendonca]

waiting for proposals

[mollfpr]

Not overdue, still waiting for proposals.

[MrMuzyk]

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

[MrMuzyk]

@lanitochka17

The account (applausetester+omc1@applause.expensifail.com) doesn't have emails suspended anymore. Do you happen to have other account that has emails suspended? I'm not able to reproduce it anymore

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mollfpr]

@NicMendonca Let's assign this issue to @MrMuzyk, so there's no proposal submitted.

[lanitochka17]

@MrMuzyk Hello
Thanks for the information, I’ll ask the testers if there is another blocked account. I'll let you know

[lanitochka17]

Hello We don't have any blocked accounts yet

[MrMuzyk]

@lanitochka17
That's too bad :( I think I've found the root cause of the issue but in order to confirm that together with the fix I need an account to test this. I've asked for help in obtaining account with suspended mailing but no luck so far.

[melvin-bot]

This issue has not been updated in over 15 days. @tgolen, @barttom, @MrMuzyk, @NicMendonca, @mollfpr eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[barttom]

The fix was merged two weeks ago, should we close this issue?

[mollfpr]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR.

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough. I think this is a case where we haven't handled it yet.

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Open the app
2. Try to log in with a suspended account (e.g. dusjosjkposakpa@gmail.com) and type continue
3. Tap back to the login screen
4. Log in with Your proper account.
5. Observe the listed chat in LHN - should have listed Your chats
6. Tap on FAB -> Tap on Request Money -> Tap on currency - should have a list of currencies
7. 👍 or 👎

@NicMendonca Could you give the payment summary so I can do the manual request? Thank you!

[NicMendonca]

BZ Summary:

• Reporter: n/a
• Contributor: @barttom (Contractor)
• C+ @mollfpr - $500 - paid via Expensify

[iwiznia]

This caused a regression. See #32590 (comment)

[JmillsExpensify]

Re-opening for the regression. Also holding payment until regression is resolved.

[JmillsExpensify]

What are the next steps here?

[NicMendonca]

bump @barttom @mollfpr! Have you had a chance to look at this regression?

[mollfpr]

Sorry, I'm unaware that the OpenApp should be called once after login.

[barttom]

Sorry, I'm also not aware of that. Looks like they proceeded solution in the other issue

[JmillsExpensify]

Alright, so are you saying that @iwiznia shouldn't have identified this issue as a regression?

[JmillsExpensify]

Let's get to the bottom of this soon, as it's delaying payment for @mollfpr until we align on whether a regression was involved or not.

[mollfpr]

@JmillsExpensify I believe there's a regression, but the root cause of the proposal was correct.

[JmillsExpensify]

Ok, so in that case, I approve the $500 payment for @mollfpr based on this comment.