[HOLD for payment 2023-11-06] [$500] [Form Provider Refactor] NewContactMethodPage

[luacmartins]

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/settings/Profile/Contacts/NewContactMethodPage.js

cc @kowczarz

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fd2034b42e8f51ab
• Upwork Job ID: 1709705014472392704
• Last Price Increase: 2023-10-05
• Automatic offers:
• abdulrahuman5196 | Reviewer | 27262140

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fd2034b42e8f51ab

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 (Internal)

[kowczarz]

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this task.

[laurenreidexpensify]

Thanks @kowczarz do you have ideas for a proposal yet?

[kowczarz]

@laurenreidexpensify that's a followup for this issue #25397 (comment). I think it would be reasonable to skip proposal similarly as it was done in function components migration and TypeScript migration.

[luacmartins]

Yep! No proposal needed here. Thanks for working on it.

[melvin-bot]

Current assignee @abdulrahuman5196 is eligible for the External assigner, not assigning anyone new.

[laurenreidexpensify]

Is there a draft PR up for this one yet?

[kowczarz]

Hey, not yet, there are 10 similar issues and I will work on them this week. I will ping you as soon as it will be ready.

[luacmartins]

waiting on PR

[laurenreidexpensify]

Do we have a PR up yet?

[luacmartins]

@cdOut can you please follow the instructions in this comment?

[kowczarz]

Hi @luacmartins, @mountiny has already added @cdOut to the upwork whitelist (details in slack dm), but it takes some time to be deployed.

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[luacmartins]

Cool, in that case I'll assign them to the issue!

[melvin-bot]

The BZ member will need to manually hire cdOut for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.92-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Form Provider Refactor] NewContactMethodPage #29869

If no regressions arise, payment will be issued on 2023-11-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment offer (Reviewer)
• @cdOut does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abdulrahuman5196]

This is a refractor issue. No checklist required.

[laurenreidexpensify]

Payment Summary -

• External issue reporter - N/A
• Contributor that fixed the issue - @cdOut payment N/A
• Contributor+ that helped on the issue and/or PR - @abdulrahuman5196 $500 payment issued in Upwork