-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Conversation - "Chat Skeleton" is blinking on Staging and Chat crashes on PROD site #28799
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01544895bdb4802211 |
Triggered auto assignment to @alexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
Not repro on Prod crash.mp4 |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @madmax330 ( |
this is probably whats causing the crash in production
|
I am not sure how to treat this, we dont have access to the account you have linked for testing, seems like production has crash and staging handles this better |
ProposalPlease re-state the problem that we are trying to solve in this issue.Conversation - "Chat Skeleton" is blinking on Staging and Chat crashes on PROD site What is the root cause of that problem?If the report hasn't been loaded yet, this function will make the app crashes when we call Lines 659 to 661 in ab821e5
What changes do you think we should make in order to solve the problem?We should use What alternative solutions did you explore? (Optional) |
@dukenv0307 can you please show me where FWIW |
@fedirjh Line 887 in ab821e5
And then we call Line 856 in ab821e5
I've encountered crashes like this before, but I don't remember how to reproduce it. So posting the proposal here may be the root cause |
@dukenv0307 I think I am not sure about this ad deploy blocker, seems more so as something odd with this specific account for testing I am going to demote this now, but leave this open for furhter investigation, if there are better repo steps not related to that specific account maybe |
To confirm, should the proposal here be reviewed, or wait for more proposals? Thanks! |
Still waiting for proposals. If no movement next week, I'll start asking around for help. |
Still waiting for proposals |
@madmax330 @alexpensify @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
We need proposals here |
ProposalPlease re-state the problem that we are trying to solve in this issue."Chat Skeleton" is blinking on Staging and Chat crashes on PROD site. What is the root cause of that problem?In my experience, blinking loop error occurs when the back-end returns an empty App/src/pages/home/ReportScreen.js Line 166 in 20cd522
In more details, if App/src/pages/home/ReportScreen.js Lines 425 to 426 in 20cd522
App/src/pages/home/ReportScreen.js Line 439 in 20cd522
By the value of
When App/src/libs/actions/Report.js Line 515 in 9ec6876
App/src/libs/actions/Report.js Line 481 in 9ec6876
Inside Because mounting of Usually, this doesn't happen because What changes do you think we should make in order to solve the problem?This is an error from the back-end but we might add an error handler for this.
We can add App/src/pages/home/ReportScreen.js Lines 386 to 393 in 18acd82
And by updating above code part, we can show appropriate error message if there is What alternative solutions did you explore? (Optional)N/A |
@fedirjh - can you review if this proposal will fix this issue? Thanks! |
@akamefi202 Can you share the response of the OpenReport API request that caused the error?
Please verify from your devtools network tab whether the request is being retried due to these race conditions. Screenshots are appreciated in this case. @akamefi202 Were you able to reproduce the crash? |
@fedirjh I'm not able to reproduce this bug. I think the reporter can confirm response of OpenReport API Request using emilio.utest@gmail.com and "I am user B" user. |
@izarutskaya Can you please retest if this bug still exists? |
@madmax330 @alexpensify @fedirjh this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks! |
@izarutskaya can you check if this is happening? If it's not let's close this out. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@izarutskaya Little bump for #28799 (comment) |
@madmax330 @alexpensify @fedirjh this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:
Thanks! |
Current assignee @fedirjh is eligible for the Internal assigner, not assigning anyone new. |
I'm just going to close this out. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
User expects the chat to load normally or some type of message appear stating that the chat can no longer be accesed
Actual Result:
The chat never loads, the "Chat skeleton" keeps on blinking and on the PROD site the conversation crashes the site and forces the user to relogin.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: v1.3.77-2
Reproducible in staging?: Y
Reproducible in production?: No, on PROD the chat Crashes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6224057_1696369362998.Crash_on_PROD_site.mp4
Bug6224057_1696369363000.Skeleton_is_blinking_on_staging.mp4
utest-dl.s3.amazonaws.com_12102_26469_432782_6224057_bugAttachment_Bug6224057_1696369362991%21Logs_from_prod_site.txt_X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20231004T110923Z&X-Amz-SignedHeaders=host&X-Amz-Expires=86400&X-Amz-Cr.txt
utest-dl.s3.amazonaws.com_12102_26469_432782_6224057_bugAttachment_Bug6224057_1696369363099%21Logs_on_staging.txt_X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20231004T110908Z&X-Amz-SignedHeaders=host&X-Amz-Expires=86400&X-Amz-Creden.txt
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: