[$500] Android - Thread - Back button is not responsive in the parent report after leaving thread #28522

lanitochka17 · 2023-09-29T19:46:01Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR #27748

Action Performed:

Launch New Expensify app
Go to any chat with thread (leave the thread if you're already in one)
Tap on the thread > Three-dot menu > Join thread
Return to LHN
Open the thread report from LHN
Tap three-dot menu > Leave thread
Tap on the back button
Tap on the back button again

Expected Result:

Back button is responsive and user is able to return to LHN

Actual Result:

Back button is not responsive and user is stuck at at the parent report of the thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.75-3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6219498_1696016051473.Screen_Recording_20230930_015322_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018b26c9446b581810
Upwork Job ID: 1708820316584988672
Last Price Increase: 2023-10-09

melvin-bot · 2023-09-29T19:46:06Z

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-29T19:46:08Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify · 2023-09-29T19:47:25Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-09-29T19:47:30Z

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

dukenv0307 · 2023-09-30T09:01:40Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Thread - Back button is not responsive in the parent report after leaving thread

What is the root cause of that problem?

We have two bugs here:

We go back to the parent report briefly before navigating to the concierge chat after leaving room

In leaveRoom function, we will go back to parent report if the room is the thread report

App/src/libs/actions/Report.js

Lines 1929 to 1931 in 52f0e3c

    
           if (report.parentReportID) { 
        
               Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.parentReportID), CONST.NAVIGATION.TYPE.FORCED_UP); 
        
               return;

But on ReportScreen, we have a useEffect that will go back to the concierge chat whenever we leaving the room

App/src/pages/home/ReportScreen.js

Lines 325 to 330 in 52f0e3c

    
               (prevOnyxReportID && prevOnyxReportID === routeReportID && !onyxReportID && prevReport.statusNum === CONST.REPORT.STATUS.OPEN && report.statusNum === CONST.REPORT.STATUS.CLOSED) 
        
           ) { 
        
               Navigation.goBack(); 
        
               Report.navigateToConciergeChat(); 
        
               return; 
        
           }

The back button is not responsive

Because we force-up here, the Home screen is replaced, and then cannot go back

App/src/libs/actions/Report.js

Lines 1929 to 1931 in 52f0e3c

    
           if (report.parentReportID) { 
        
               Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.parentReportID), CONST.NAVIGATION.TYPE.FORCED_UP); 
        
               return;

What changes do you think we should make in order to solve the problem?

If we always want to go back to concierge chat after leaving room, we can remove the navigate logic in leaveRoom function because we already have this in ReportScreen

App/src/libs/actions/Report.js

Lines 1925 to 1935 in 52f0e3c

    
               Navigation.dismissModal(); 
        
               if (Navigation.getTopmostReportId() === reportID) { 
        
                   Navigation.goBack(ROUTES.HOME); 
        
               } 
        
               if (report.parentReportID) { 
        
                   Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.parentReportID), CONST.NAVIGATION.TYPE.FORCED_UP); 
        
                   return; 
        
               } 
        
               navigateToConciergeChat(); 
        
           }

If not, we can remove the optimistic case here as we only want to do this if we leave room on another device

if (!prevUserLeavingStatus && userLeavingStatus) { 
    Navigation.goBack();
    Report.navigateToConciergeChat();
    return;
}

App/src/pages/home/ReportScreen.js

Lines 325 to 330 in 52f0e3c

    
               (prevOnyxReportID && prevOnyxReportID === routeReportID && !onyxReportID && prevReport.statusNum === CONST.REPORT.STATUS.OPEN && report.statusNum === CONST.REPORT.STATUS.CLOSED) 
        
           ) { 
        
               Navigation.goBack(); 
        
               Report.navigateToConciergeChat(); 
        
               return; 
        
           }

And we need to move this block here to above here

App/src/libs/actions/Report.js

Lines 1929 to 1931 in 52f0e3c

    
           if (report.parentReportID) { 
        
               Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.parentReportID), CONST.NAVIGATION.TYPE.FORCED_UP); 
        
               return;

What alternative solutions did you explore? (Optional)

mountiny · 2023-10-01T08:02:01Z

@dukenv0307 Thanks for the proposal, looks good to me but given this is a deploy blocker, can you highlight which PR caused this issue as that will be the real RCA.

dukenv0307 · 2023-10-01T08:06:19Z

@mountiny This coming from this PR #24407 that added the logic to go to concierge chat in ReportScreen

wildan-m · 2023-10-01T10:45:12Z

Hi, I think we can't go with option 2.

Removing an optimistic case will make another tab in the same browser session not navigated to the concierge, it will show "hmmm page not found"

allroundexperts · 2023-10-01T10:47:51Z

@mountiny This was a very tricky PR because of so many edge cases. The PR itself is a regression fix PR. I think we should just revert #24407 and go to the drawing board again. Unless @wildan-m can fix this with a better solution.

wildan-m · 2023-10-01T10:53:43Z

Agree with @allroundexperts, please revert my PR, I'm on limited availability today

mountiny · 2023-10-01T10:56:05Z

I like the revert approach as this is indeed tricky. @allroundexperts would you be able to make the revert pr for this?

allroundexperts · 2023-10-01T10:57:11Z

@mountiny I will be in ~4 hours. I'm on my mobile currently.

hoangzinh · 2023-10-01T11:05:49Z

I think #24407 is not a PR causing this deploy blocker. Because I tried to revert this PR in my local but it doesn't fix this deploy blocker.

Proof

Screen.Recording.2023-10-01.at.17.53.23.mov

IMO, It should be:

The PR Fix: Leaving thread navigates to Concierge page #27127 is the offending PR of this deploy blocker
- (checkout my recording for proof, when I revert that PR, this deploy blocker is not reproducible).
The PR Wildan/fix/21518/client pusher method #24407 is the offending PR of Fix: Leaving thread navigates to Concierge page #27127
- (because from Fix: Leaving thread navigates to Concierge page #27127 we're expecting if we leave a thread report, it should navigation to the parent report, but after Wildan/fix/21518/client pusher method #24407 it navigates to the Concierge report)

wildan-m · 2023-10-02T07:13:35Z

I'm the author of #24407, I don't see it as regression since the expected behavior change.

IMO the root cause is there is a redundant pop of navigation history, it uses goBack and also CONST.NAVIGATION.TYPE.FORCED_UP which will replace the navigation.

I'd recommend to make this change:

In LeaveRoom function, switch goBack position with goToParent

    Navigation.dismissModal();
    if (report.parentReportID) {
        Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.parentReportID), CONST.NAVIGATION.TYPE.FORCED_UP);
        return;
    }
    if (Navigation.getTopmostReportId() === reportID) {
        Navigation.goBack(ROUTES.HOME);
    }
    navigateToConciergeChat();

For ReportScreen add new condition to go to parent if it's a thread

        // Navigate to the Concierge chat if the room was removed from another device (e.g. user leaving a room)
        if (
            // non-optimistic case
            (!prevUserLeavingStatus && userLeavingStatus) ||
            // optimistic case
            (prevOnyxReportID && prevOnyxReportID === routeReportID && !onyxReportID && prevReport.statusNum === CONST.REPORT.STATUS.OPEN && report.statusNum === CONST.REPORT.STATUS.CLOSED)
        ) {
            if (report.parentReportID) {
                Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.parentReportID), CONST.NAVIGATION.TYPE.FORCED_UP);
                return;
            }

            Navigation.goBack();
            Report.navigateToConciergeChat();
            return;
        }

melvin-bot · 2023-10-02T12:24:54Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

mountiny · 2023-10-02T12:25:59Z

Based on this conversation https://expensify.slack.com/archives/C01GTK53T8Q/p1696249324397149?thread_ts=1696016845.380819&cid=C01GTK53T8Q its reproducible in production but just a different steps as we moved the join/leave thread buttons around. The core issue is not a blocker though

Screen.Recording.2023-10-02.at.19.19.10.mov

greg-schroeder · 2023-10-02T15:14:49Z

Not overdue Melv

wildan-m · 2023-10-02T21:04:46Z

I can't reproduce it with the latest main.

Now, for expected behavior change, we'll just add this code

if (report.parentReportID) {
                Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.parentReportID), CONST.NAVIGATION.TYPE.FORCED_UP);
                return;
            }

to ReportScreen as suggested here.

again, I feel this is not a regression but a change to the requirement, holding this for more weeks seems not to be fair.

@allroundexperts what's your opinion?

allroundexperts · 2023-10-03T00:33:06Z

again, I feel this is not a regression but a change to the requirement, holding this for more weeks seems not to be fair.

I would agree with with you here.

greg-schroeder · 2023-10-06T07:20:48Z

I don't think the linked issue should be held as a regression personally. It would be if we hadn't adjusted the behavior, but we did, so... I tend to agree as well

greg-schroeder · 2023-10-06T07:22:47Z

@jjcoffee @allroundexperts @mountiny are we treating this as an open proposal review then and not a regression fix that @wildan-m should take on automatically? a bit confused where to go from here

wildan-m · 2023-10-06T07:26:40Z

@greg-schroeder, based on this and this. My PR is not directly related to this issue. The issue persisted even after my PR reverted.

greg-schroeder · 2023-10-06T07:38:12Z

Yes I understand. Are you still making a proposal to resolve this issue anyway, or no?

wildan-m · 2023-10-06T07:47:06Z

@greg-schroeder, not yet, I'm working on another issue also resolve the requirement change caused by this PR #27127

Also, the last time I checked this issue was not reproducible with the latest main

greg-schroeder · 2023-10-06T07:58:29Z

👍 okay I will try again to reproduce

melvin-bot · 2023-10-09T11:27:51Z

@AndrewGable, @jjcoffee, @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot · 2023-10-09T16:00:39Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

greg-schroeder · 2023-10-10T16:26:27Z

Will get to this during the week. also @jjcoffee or @allroundexperts can either of you help confirm if it's reproducible or not with the different steps?

mvtglobally · 2023-10-12T03:44:28Z

Issue not reproducible during KI retests. (First week)

melvin-bot · 2023-10-13T11:49:42Z

@AndrewGable @jjcoffee @greg-schroeder this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

greg-schroeder · 2023-10-13T19:11:30Z

I cannot repro

greg-schroeder · 2023-10-16T14:48:40Z

It seems maybe this was fixed elsewhere - nobody can repro. Going to close then.

lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 29, 2023

melvin-bot bot assigned greg-schroeder Sep 29, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 29, 2023

OSBotify mentioned this issue Sep 29, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

melvin-bot bot assigned AndrewGable Sep 29, 2023

melvin-bot bot mentioned this issue Oct 1, 2023

[HOLD for payment 2023-10-02] [$500] Leaving threads lands you in concierge chat #26250

Closed

6 tasks

melvin-bot bot added the Overdue label Oct 2, 2023

mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 2, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 2, 2023

melvin-bot bot assigned jjcoffee Oct 2, 2023

melvin-bot bot removed the Overdue label Oct 2, 2023

melvin-bot bot added the Overdue label Oct 5, 2023

melvin-bot bot removed the Overdue label Oct 6, 2023

melvin-bot bot added the Overdue label Oct 9, 2023

melvin-bot bot removed the Overdue label Oct 10, 2023

melvin-bot bot added the Overdue label Oct 13, 2023

melvin-bot bot added Overdue and removed Overdue labels Oct 13, 2023

greg-schroeder closed this as completed Oct 16, 2023

melvin-bot bot removed the Overdue label Oct 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$500] Android - Thread - Back button is not responsive in the parent report after leaving thread #28522

[$500] Android - Thread - Back button is not responsive in the parent report after leaving thread #28522

lanitochka17 commented Sep 29, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 29, 2023

melvin-bot bot commented Sep 29, 2023

OSBotify commented Sep 29, 2023

melvin-bot bot commented Sep 29, 2023

dukenv0307 commented Sep 30, 2023

mountiny commented Oct 1, 2023

dukenv0307 commented Oct 1, 2023

wildan-m commented Oct 1, 2023

allroundexperts commented Oct 1, 2023

wildan-m commented Oct 1, 2023

mountiny commented Oct 1, 2023

allroundexperts commented Oct 1, 2023

hoangzinh commented Oct 1, 2023

wildan-m commented Oct 2, 2023 •

edited

Loading

melvin-bot bot commented Oct 2, 2023

mountiny commented Oct 2, 2023

greg-schroeder commented Oct 2, 2023

wildan-m commented Oct 2, 2023

allroundexperts commented Oct 3, 2023

greg-schroeder commented Oct 6, 2023

greg-schroeder commented Oct 6, 2023

wildan-m commented Oct 6, 2023

greg-schroeder commented Oct 6, 2023

wildan-m commented Oct 6, 2023

greg-schroeder commented Oct 6, 2023

melvin-bot bot commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

greg-schroeder commented Oct 10, 2023

mvtglobally commented Oct 12, 2023

melvin-bot bot commented Oct 13, 2023

greg-schroeder commented Oct 13, 2023

greg-schroeder commented Oct 16, 2023

[$500] Android - Thread - Back button is not responsive in the parent report after leaving thread #28522

[$500] Android - Thread - Back button is not responsive in the parent report after leaving thread #28522

Comments

lanitochka17 commented Sep 29, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Sep 29, 2023

melvin-bot bot commented Sep 29, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented Sep 29, 2023

melvin-bot bot commented Sep 29, 2023

dukenv0307 commented Sep 30, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

mountiny commented Oct 1, 2023

dukenv0307 commented Oct 1, 2023

wildan-m commented Oct 1, 2023

allroundexperts commented Oct 1, 2023

wildan-m commented Oct 1, 2023

mountiny commented Oct 1, 2023

allroundexperts commented Oct 1, 2023

hoangzinh commented Oct 1, 2023

wildan-m commented Oct 2, 2023 • edited Loading

melvin-bot bot commented Oct 2, 2023

mountiny commented Oct 2, 2023

greg-schroeder commented Oct 2, 2023

wildan-m commented Oct 2, 2023

allroundexperts commented Oct 3, 2023

greg-schroeder commented Oct 6, 2023

greg-schroeder commented Oct 6, 2023

wildan-m commented Oct 6, 2023

greg-schroeder commented Oct 6, 2023

wildan-m commented Oct 6, 2023

greg-schroeder commented Oct 6, 2023

melvin-bot bot commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

greg-schroeder commented Oct 10, 2023

mvtglobally commented Oct 12, 2023

melvin-bot bot commented Oct 13, 2023

greg-schroeder commented Oct 13, 2023

greg-schroeder commented Oct 16, 2023

lanitochka17 commented Sep 29, 2023 •

edited by melvin-bot bot

Loading

wildan-m commented Oct 2, 2023 •

edited

Loading