[HOLD for payment 2023-09-27] [Awaiting Payment] App crash when requesting money

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click plus button
2. Choose Request Money
3. Notice that app is crashed

Expected Result:

App shouldn't be crashed when requesting money

Actual Result:

App crash when requesting money

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70-1
Reproducible in staging?: needs repro
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-15.at.09.27.58.mov

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694744871014989

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012f7286e4699d038d
• Upwork Job ID: 1703625475185655808
• Last Price Increase: 2023-09-18

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012f7286e4699d038d

[melvin-bot]

Current assignee @situchan is eligible for the Internal assigner, not assigning anyone new.

[grgia]

@alexpensify I fixed this in
#27483
So we just need to handle C+ review payment for @situchan
and reporting payment to @hungvu193

[alexpensify]

@grgia - is this ready for payment or do I need to wait the standard hold period to confirm no regression?

[grgia]

@alexpensify ah good point. My PR caused #27453 which @roryabraham is working on #27482

[situchan]

#27453 existed before crash fix PR.
So that regression should affect original PR - #26775, not this one - #27487

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix undefined color keys #27483

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @situchan requires payment
• @hungvu193 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[maddylewis]

i also have this issue opened - #26775

is payment being handled on this issue? lmk - thx!

[situchan]

Payment can be handled separately.
Here in #27487, payment is due on Sep 27 for me @situchan (C+) and @hungvu193 (bug report)
In #21016, payment is due on Sep 27 for @allroundexperts (C+)

In #27453, payment is due on N/A (PR not merged yet) for @gadhiyamanan (bug report)
In #26775, payment is due on Sep 21 for @hungvu193 (C)

This issue (#27487) is regression from #21016
#27453 is regression from #26775
So penalty would be applied to #21016 and #26775

[alexpensify]

I'll be working on the payment process today. Thank you @situchan for the summary! Please complete the summary too and we can close this GH after I complete the payment process. Thanks!

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: Add Light Theme light.js and clean up colors.js  #22986
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add Light Theme light.js and clean up colors.js  #22986 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

FAB > Request Money is major flow of the app and I believe this should be already in Testrail and run on every deploy.
No need separate regression test case.

[alexpensify]

Here is the payment summary:

• External issue reporter - @hungvu193 $50
• Contributor that fixed the issue - N/A Internal
• Contributor+ that helped on the issue and/or PR - @situchan $500 + $250

Upwork Job: https://www.upwork.com/jobs/~012f7286e4699d038d

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: This was deployed within the urgency bonus window. There will be a bonus here.

[alexpensify]

I've sent the Upwork requests. Please accept and I can complete the process. Thanks!

[hungvu193]

I've sent the Upwork requests. Please accept and I can complete the process. Thanks!

Accepted, thank you!

[alexpensify]

Done, everyone has been paid in Upwork. Thank you!