[HOLD for payment 2023-10-02] [$500] Dev - Request Money/Scan: Error message persist after reloading

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click plus button, choose Request money
2. Choose Scan tab, drag a large video to Scan tab (Video > 24 MB).
3. Notice that's a error display.
4. Refresh the app.

Expected Result:

Error modal should disappear after reloading

Actual Result:

Error modal doesn't disappear after reloading

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.69-0
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-02.at.09.18.58.mov

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692776477205919

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0168e8e1059435aa00
• Upwork Job ID: 1702152112042070016
• Last Price Increase: 2023-09-14
• Automatic offers:
• hungvu193 | Contributor | 26730557
• hungvu193 | Reporter | 26730558

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0168e8e1059435aa00

[mvtglobally]

Original proposal from reporter

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request Money/Scan: Error message persist after reloading

What is the root cause of that problem?

We're storing scan validation error in our Onyx and only clear them when user press Close button from Validation Modal, because of that, when user reloaded the page, the Validation Modal still persisted.

App/src/pages/iou/ReceiptSelector/index.js

Lines 163 to 164 in 4f412db

	onConfirm={Receipt.clearUploadReceiptError}
	onCancel={Receipt.clearUploadReceiptError}

What changes do you think we should make in order to solve the problem?

We can add an useEffect and clear the error:

    React.useEffect(() => {
        Receipt.clearUploadReceiptError();
    }, []);

What alternative solutions did you explore? (Optional)

Instead of storing error in our Onyx, we can use local state to do that, with this approach we don't need to worry about reloading.
By bringing validateReceipt into ReceiptSelector, and refactor Receipt.setUploadReceiptError to use local state similar way we use to validate in other screens (ie: AttachmentWithImagePicker...)

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @alexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[flaviadefaria]

@burczu can you confirm if you're able to reproduce this?

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[flaviadefaria]

@adelekennedy I'm going OoO for a week so assigning this to you so that you can move it forward in the meantime. I'll take it back from you once I'm online again.

[burczu]

@burczu can you confirm if you're able to reproduce this?

@flaviadefaria @adelekennedy I confirm it is reproducible.

[adelekennedy]

confirmed reproducible @burczu can you also review the proposal above?

[burczu]

@adelekennedy yes, I'll do it soon

[burczu]

I've reviewed the proposal from @mvtglobally and I think it is correct. Personally I prefer the optional solution where we switch to use local state instead of using Onyx, but maybe I'm missing something and we are keeping this data in Onyx for a reason (then the main solution from this proposal is also correct, in my opinion).

🎀 👀 🎀 C+ reviewed

[melvin-bot]

🎯 ⚡️ Woah @burczu / @hungvu193, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @hungvu193 got assigned: 2023-09-18 11:17:50 Z
• when the PR got merged: 2023-09-20 13:22:55 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix persist receipt error #27664

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @hungvu193 requires payment offer (Contributor)
• @hungvu193 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR:
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy / @flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[burczu]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR: Didn't find - it looks like it was done this way almost from the beginning.
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy / @flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[pradeepmdk]

i think It creates a regression here #28343
there is no const value UNALLOWED_EXTENSIONS

cc : @hungvu193

[hungvu193]

i think It creates a regression here #28343

there is no const value UNALLOWED_EXTENSIONS

cc : @hungvu193

Ah No, it was there from start, I only move it from Receipt to new place. Please checkout the diff 😃

[roryabraham]

@adelekennedy @flaviadefaria Looks like this is ready to pay

[adelekennedy]

@flaviadefaria I'm now going ooo if you don't mind closing it out!

[roryabraham]

@flaviadefaria looks like payment is the last step here. Thanks! 🤑

[flaviadefaria]

Payment summary:

For reference, here are some details about the assignees on this issue:
@burczu does not require payment (Contractor)
@hungvu193 requires payment offer (Contributor)
@hungvu193 requires payment offer (Contributor)

@hungvu193 - reporting bonus = $50
@hungvu193 - $500 + $250 (50% bonus) = $750

[flaviadefaria]

@hungvu193 I didn't realize we had sent you a single contract so had to send a new one for the reporting bonus as I had already paid the other one. Please accept it so that I can pay it. Thank you!

[flaviadefaria]

Everyone has been paid!