[HOLD for payment 2023-10-10] [$500] Public room - Unable to copy link as an anonymous user

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create new public room.
2. Send a normal message and a link in the room.
3. Open the room in incognito by copy pasting the URL.
4. Right click on the sent link
5. Click on 'copy url to clipboard'

Expected Result:

Just like the 'copy to clipboard' option, 'copy URL to clipboard' shouldn't require the user to sign in.

Actual Result:

It is required to sign-in to copy a URL to clipboard.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.66-3

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-29.At.11.05.05.Pm.mp4

Recording.1488.mp4

Expensify/Expensify Issue URL:

Issue reported by: @esh-g

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693330719748079

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01666b3569fccb8232
• Upwork Job ID: 1701195487091564544
• Last Price Increase: 2023-09-11
• Automatic offers:
• esh-g | Contributor | 26880395
• esh-g | Reporter | 26880399

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to copy link as an anonymous user.

What is the root cause of that problem?

We set isAnonymousAction for these actions as false. So anonymous user unable to copy link

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 146 to 147 in 6e17b64

	isAnonymousAction: false,
	textTranslateKey: 'reportActionContextMenu.copyURLToClipboard',

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 159 to 160 in 6e17b64

	isAnonymousAction: false,
	textTranslateKey: 'reportActionContextMenu.copyEmailToClipboard',

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 222 to 223 in 6e17b64

	isAnonymousAction: false,
	textTranslateKey: 'reportActionContextMenu.copyLink',

What changes do you think we should make in order to solve the problem?

If we decide to copy link, I think we should accept anonymous users can do all copy action by change isAnonymousAction for these action to true

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 146 to 147 in 6e17b64

	isAnonymousAction: false,
	textTranslateKey: 'reportActionContextMenu.copyURLToClipboard',

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 159 to 160 in 6e17b64

	isAnonymousAction: false,
	textTranslateKey: 'reportActionContextMenu.copyEmailToClipboard',

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 222 to 223 in 6e17b64

	isAnonymousAction: false,
	textTranslateKey: 'reportActionContextMenu.copyLink',

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[esh-g]

@izarutskaya I had posted a proposal in slack. Please post it here if possible.. Or let me know if I should do so

[izarutskaya]

Proposal from @esh-g

Please re-state the problem

Unable to use copy URL to clipboard and copy email to clipboard as an anonymous user.

What is the root cause of this problem?

We have not set the isAnonymousAction to true for these actions in contextMenuAction.js

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 145 to 148 in a8e2a6a

	{
	isAnonymousAction: false,
	textTranslateKey: 'reportActionContextMenu.copyURLToClipboard',
	icon: Expensicons.Copy,

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 158 to 160 in a8e2a6a

	{
	isAnonymousAction: false,
	textTranslateKey: 'reportActionContextMenu.copyEmailToClipboard',

What changes should be made to fix this?

We should set the isAnonymousAction property for the listed items to be true since this action shouldn't require any kind of authentication. We even allow attachments to be downloaded by an anonymous user, therefore I think allowing the copying of URLs and emails is the right step.

[bfitzexpensify]

Sending external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01666b3569fccb8232

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[bfitzexpensify]

Couple of proposals ready for review when you get a chance @sobitneupane - thank you!

[sobitneupane]

Thanks for proposal everyone.

Proposal from @esh-g looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[bfitzexpensify]

How does the proposal from @esh-g look @youssef-lr?

[bfitzexpensify]

Not sure why Melv re-added the overdue label

[melvin-bot]

@youssef-lr @sobitneupane @bfitzexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[bfitzexpensify]

Bump for review @youssef-lr

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @esh-g got assigned: 2023-09-26 09:36:01 Z
• when the PR got merged: 2023-10-02 10:12:14 UTC
• days elapsed: 4

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow anonymous user to copy url #28261

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @sobitneupane does not require payment (Eligible for Manual Requests)
• @esh-g requires payment offer (Contributor)
• @esh-g requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

Switching this to daily so I'm aware of it and action it on 10/10

[bfitzexpensify]

@esh-g since there were no issues with the PR raised and the delay was due to illness, I am going to consider this eligible for the urgency bonus.

[bfitzexpensify]

Payment due for this on Tuesday.

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#22321

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

I don't think this can be considered as regression. https://github.com/Expensify/App/pull/22321/files#r1349995627

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• [@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#27039 (comment)

[sobitneupane]

Regression Test Proposal

1. Create a new public room.
2. Send a message as a url and an email
3. Go to room details and copy the room url from QR code screen.
4. Go to a guest tab and paste the url
5. Make sure we are able to copy the link and email by right clicking on them.

Do we agree 👍 or 👎

[bfitzexpensify]

Payment summary:

Reporter: @esh-g - $50 to be paid via Upwork
Contributor: @esh-g - $750 to be paid via Upwork
C+: @sobitneupane - $750 to be paid via manual request

[bfitzexpensify]

Payments complete, regression steps proposed via https://github.com/Expensify/Expensify/issues/325765, think we're all done here

[sobitneupane]

#27039 (comment)

Requested payment on newDot.

[JmillsExpensify]

$750 payment approved for @sobitneupane based on this comment.