[HOLD for payment 2023-10-02] [$500] Reimbursements - Track distance: inconsistency in units capitalization

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Workspace settings -> Reimbursements -> Track Distance
2. Open the "Unit" dropdown

Expected Result:

Both "Miles" and "Kilometers" should be either capitalized or not.

Actual Result:

"Kilometers" starts from uppercase letter, "miles" – lowercase.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.65.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Loom.Message.-.2.September.2023.mp4

Recording.4301.mp4

Expensify/Expensify Issue URL:
Issue reported by: @paultsimura

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693685221686339

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cf988c4c1ae85fdd
• Upwork Job ID: 1701545859200626688
• Last Price Increase: 2023-09-12
• Automatic offers:
• paultsimura | Contributor | 26724769
• paultsimura | Reporter | 26724772

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Issue reported by: @paultsimura
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693685221686339

Proposal

Please re-state the problem that we are trying to solve in this issue.

Kilometers and miles units have different capitalization style

What is the root cause of that problem?

We are using inconsistent copies:
reimburse.kilometers: 'Kilometers'
common.miles: 'miles'

App/src/pages/workspace/reimburse/WorkspaceRateAndUnitPage.js

Lines 42 to 47 in d7ab640

	getUnitItems() {
	return [
	{label: this.props.translate('workspace.reimburse.kilometers'), value: CONST.CUSTOM_UNITS.DISTANCE_UNIT_KILOMETERS},
	{label: this.props.translate('common.miles'), value: CONST.CUSTOM_UNITS.DISTANCE_UNIT_MILES},
	];
	}

This issue was introduced in this commit: d7ab640

What changes do you think we should make in order to solve the problem?

Use one of the following:
reimburse.kilometers and reimburse.miles with capitalized letter;
common.kilometers and common.miles with all lowercase (IMO this one is preferred).

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@sonialiap Huh... This is 4 days overdue. Who can take care of this?

[sonialiap]

Standardizing on lowercase sounds good to me 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cf988c4c1ae85fdd

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @peterdbarkerUK (External)

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[burczu]

Yes, the proposal from @kbecciv makes sense and we can proceed with it (with lowercase copies - #26897 (comment)).

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[paultsimura]

Thank you, waiting for assignment and creating the PR right after.
Also @kbecciv thank you for going an extra mile and sharing the proposal from thread 🙏

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[madmax330]

not overdue

[JmillsExpensify]

Agree with standardizing on lowercase.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @paultsimura got assigned: 2023-09-18 04:20:51 Z
• when the PR got merged: 2023-09-22 11:38:24 UTC
• days elapsed: 4

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Reimbursements - Track distance: inconsistency in units capitalization #27640

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @paultsimura requires payment offer (Contributor)
• @paultsimura requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR:
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[burczu]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR: Modify MoneyRequestConfirmPage for Distance Request #25707
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Modify MoneyRequestConfirmPage for Distance Request #25707 (comment)
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Didn't find
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sonialiap]

@paultsimura report = $50 - paid ✔️
@paultsimura fix + bonus = $500 + $250 = $750 - paid ✔️
@burczu does not require payment (Contractor)