[HOLD for payment 2023-09-13] [$250] [Distance] - Next button hidden and unable to complete distance money request

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #26601

Action Performed:

1. Request money for a distance request.
2. After adding all the necessary data

Expected Result:

Next Button visible to select or page scrollable to select Next button

Actual Result:

Next button hidden and unable to scroll the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.63-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0166ea6d21ec0ea15e
• Upwork Job ID: 1699360845004812288
• Last Price Increase: 2023-09-06

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Next button hidden and unable to complete distance money request

What is the root cause of that problem?

In our DistanceRequest page, we have difference view with difference minHeight ( 128 for waypoint, 300 for the map), because of that when the screen size is too small, the Next button will be hidden.

What changes do you think we should make in order to solve the problem?

We should wrap the content (except the Next button) inside a View, and wrap the Next button with FixedFooter.

 < >
   <View style={[styles.flex1, styles.overflowHidden]}>
   {/** All the content */}
  </View >
  <FixedFooter style={[styles.w100, styles.ph4, styles.flexShrink0]}>
    <Button
        success
        onPress={() => IOU.navigateToNextPage(iou, iouType, reportID, report)}
        isDisabled={_.size(validatedWaypoints) < 2}
        text={translate('common.next')}
   />
  </FixedFooter >

         

What alternative solutions did you explore? (Optional)

N/A

Result

Screen.Recording.2023-09-05.at.10.32.29.mov

[hungvu193]

oh found out it's dupe of: #26541

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[joh42]

@mountiny seems like this PR fixed it #26728
Now you can scroll down to the button

[mountiny]

PR being cherry picked to staging

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.63-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: wrap distance request inside scrollable view #26728

If no regressions arise, payment will be issued on 2023-09-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Gonals] The PR that introduced the bug has been identified. Link to the PR:
• [@Gonals] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Gonals] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Gonals] Determine if we should create a regression test for this bug.
• [@Gonals] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

PR is being CPed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.64-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: wrap distance request inside scrollable view #26728
• [CP Staging] fix: change the contentContainerStyle for the DistanceRequest scroll view #26859

If no regressions arise, payment will be issued on 2023-09-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.65-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: change the contentContainerStyle for the DistanceRequest scroll view #26859

If no regressions arise, payment will be issued on 2023-09-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[akinwale]

@alexpensify Just checking in here. My PR for this was initially deployed to production on 2023-09-06 (reference), so it looks like the correct payment date is 2023-09-13, and the bot got a little carried away.

@mountiny Do I need to do anything with the checklist here?

[mountiny]

I think we dont need the cheklist here as it was a new feature for the conference so not really regressions

[alexpensify]

@akinwale - sorry, I was OOO the past two days and still catching up. I thought the payment date was on September 15, so that's why I didn't reassign. Can you please apply for the job here: https://www.upwork.com/jobs/~0166ea6d21ec0ea15e? Tomorrow, I'll complete the payment process. Thanks!

[akinwale]

@alexpensify Applied. Thanks!

[alexpensify]

Thanks, I've continued the process in Upwork and need you to accept @akinwale.

[akinwale]

Thanks, I've continued the process in Upwork and need you to accept @akinwale.

@alexpensify Accepted, thanks.

[alexpensify]

Awesome, I've completed the process in Upwork. Thanks for your help here!

[alexpensify]

Here is the payment summary:

• External issue reporter N/A
• Contributor that fixed the issue @akinwale $250
• Contributor+ that helped on the issue and/or PR N/A

Upwork Job: https://www.upwork.com/jobs/~0166ea6d21ec0ea15e

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: N/A