[HOLD for payment 2023-11-01] Improve the IOUTest with Edit, delete and payment with ACH

[mountiny]

Problem

Stemming from #23961

We are actively working on new features for the money request flows, where we have now added ability to delete the request, edit it or we have an option to pay the request with ACH payment type which puts the report into slightly different state than when paying the report with different payment type. The state of the report is 3 BILLING whereas report paid with different type has state 2. Both reports have status 4.

But these new features have not been captured in IOUTest. Lets add it.

Solution

Lets beef up our automated tests, think of many various solutions and really try to capture as much of the optimistic flow there as possible. In the end what we can se can be translated to the Onyx state so we can test if the onyx state is correctly updated during the flow and we are showing a report is settled when its settled for example.

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

cc @koko57 or @allroundexperts might be interested.

[melvin-bot]

Current assignee @tjferriss is eligible for the NewFeature assigner, not assigning anyone new.

[allroundexperts]

I can take this one!

[mountiny]

All yours

[allroundexperts]

PR is in works!

[tjferriss]

@allroundexperts how is the PR coming along?

[allroundexperts]

Apologies for the delay. PR created.

[tjferriss]

It looks like we're waiting to resolve a few items on the PR then we should be good to merge it.

[melvin-bot]

This issue has not been updated in over 15 days. @tjferriss, @allroundexperts, @mountiny eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

@allroundexperts I have shared with you some tips for the next steps in the PR, we should be close to completing this

[allroundexperts]

Yep. I'll handle this today / tomorrow.

[mountiny]

Merged but I think we would actually want to add more tests for all the expense fields

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.90-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] feat: add unit tests for edit money request and payment via vbba #27609

If no regressions arise, payment will be issued on 2023-11-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[mountiny]

@tjferriss this should be $500 to @allroundexperts nothing else, thank you!

[tjferriss]

@mountiny @allroundexperts should that payment be through Upworks?

[allroundexperts]

@tjferriss New Dot!

[mountiny]

@allroundexperts requested on newdot so we can close now

[JmillsExpensify]

$500 payment approved for @allroundexperts based on this comment.