[$1000] Chat - Composer Not focused when clicking on composer box #25892

lanitochka17 · 2023-08-24T20:25:35Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to any chat
Send a message
Click on Edit from the reaction menu
Click on the emoji menu in the edit composer
Now without closing the emoji box click on the main composer

Expected Result:

Clicking on the main composer box focuses the composer

Actual Result:

Clicking on the main composer box focuses on the main composer for a second and then focuses on the edit Composer

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.57-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

T106-1_EditComposerFocus.mp4

Gravar.2966.mp4

Expensify/Expensify Issue URL:

Issue reported by: @daveSeife

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692048812228079

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0161d746e7dbb99cde
Upwork Job ID: 1695206421110677504
Last Price Increase: 2023-09-15
Automatic offers:

tienifr | Contributor | 26745373
daveSeife | Reporter | 26745374

melvin-bot · 2023-08-24T20:25:39Z

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-08-24T20:25:41Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

hoangzinh · 2023-08-25T09:49:44Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Composer Not focused when clicking on composer box

What is the root cause of that problem?

In the ReportActionItemMessageEdit component, we have a callback when Emoji picker modal is hidden, it will focus back to the editing report message

App/src/pages/home/report/ReportActionItemMessageEdit.js

Lines 379 to 382 in 34d4e54

    
           onModalHide={() => { 
        
               setIsFocused(true); 
        
               focus(true); 
        
           }}

So even if we click focus on the main composer, by above callback, it will focus back to the editing report message

What changes do you think we should make in order to solve the problem?

In the above onModalHide callback, we need to check if the main composer is focusing, we will early exit and won't focus back to the editing report message

Result:

Screen.Recording.2023-08-25.at.16.49.54.mov

melvin-bot · 2023-08-25T22:48:03Z

Job added to Upwork: https://www.upwork.com/jobs/~0161d746e7dbb99cde

melvin-bot · 2023-08-25T22:48:06Z

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-08-25T22:48:12Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

tienifr · 2023-08-26T00:24:11Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Composer Not focused when clicking on composer box

What is the root cause of that problem?

When Emoji picker modal is closed, it will focus back to the edit composer regardless of any user interaction:

App/src/pages/home/report/ReportActionItemMessageEdit.js

Lines 379 to 382 in 253db32

    
           onModalHide={() => { 
        
               setIsFocused(true); 
        
               focus(true); 
        
           }}

So even if we click focus on the main compose, it will always focus back to the edit compose.

What changes do you think we should make in order to solve the problem?

Update: As previously discussed here, we should move all ReportActionComposeFocusManager-related codes out of the standalone Composer.

Since PR #24481, we have a way to re-focus on the "right" compose:

general composer (including the edit composer): If this is the last composer that was focused on, we want to refocus on this
main composer: If there's no last composer that was focused on before, this should be the fallback composer that we need to focus

So there's no need for manual check for currently focused compose because ReportActionFocusManager will handle it. In ReportActionItemMessageEdit:

onModalHide={() => {
    ReportActionComposeFocusManager.focus();
}}

Add the onComposerFocus callback:

onFocus={() => {
    ...
    ReportActionComposeFocusManager.onComposerFocus(() => {
        if (!willBlurTextInputOnTapOutside) {
            return;
        }
        focus(true);
    });
}}

And unsubscribe it using ReportActionComposeFocusManager.clear() on unmount
Remove all ReportActionComposeFocusManager-related codes out of the standalone Composer

parasharrajat · 2023-08-27T10:14:40Z

OK. Thanks for the proposals. My intuition is asking to hold this issue as we have done for #23403. Even though solutions might not overlap they seem quite related.

Also, I was checking on #24481 and the implementation doesn't seem very scalable. This is out of the scope of this issue but we can pursue improving that as well.

rojiphil · 2023-08-28T06:31:29Z

Isn’t this an expected behaviour? When the EmojiPicker is displayed, we do not allow interactions with any other element in Report Screen until it is dismissed. A tap on anywhere else other than the EmojiPicker will hide and bring the focus back on the currently edited message input.

parasharrajat · 2023-08-28T08:09:36Z

That was the behavior a few months back but it seems that it is recently changed. I am not sure where.

MitchExpensify · 2023-08-30T16:51:50Z

@parasharrajat do you still think this is the best course of action here?

My intuition is asking to hold this issue as we have done for #23403.

parasharrajat · 2023-08-31T03:56:36Z

The reason behind this is that a single PR caused these issues and C+ can pick a more complete solution in #23403 to fix the issue completely. I am monitoring the review of the other issue. If it seems that we are not solving this issue there, I will continue here.

Does that sound good? or do you want me to continue on this issue?

melvin-bot · 2023-09-01T16:00:05Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

MitchExpensify · 2023-09-03T13:17:45Z

I am monitoring the review of the other issue. If it seems that we are not solving this issue there, I will continue here.

This sounds great to me! Thank you

tienifr · 2023-09-06T09:27:30Z

@parasharrajat As previously discussed here, I updated my proposal to refactor the ReportActionComposeFocusManager codes. I've run through all test cases in related PRs: #23258, #24481 and #23994 and it worked fine.

MitchExpensify · 2023-09-06T12:06:16Z

Sounds like @tienifr's proposal is updated and ready for you @parasharrajat

melvin-bot · 2023-09-08T16:00:32Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

isabelastisser · 2024-07-18T18:26:37Z

Bump @parasharrajat, can you please provide an update? Thanks!

tienifr · 2024-07-22T02:23:24Z

After PRs related to #24452 were merged, this issue is still reproducible. I'll take a look and update in our PR.

parasharrajat · 2024-07-22T09:38:23Z

Thanks @tienifr. Ping me when you have next update.

parasharrajat · 2024-07-31T22:00:07Z

@tienifr Any updates?

isabelastisser · 2024-08-05T15:55:55Z

@tienifr, please provide an update. I will DM you for visibility. Thanks!

tienifr · 2024-08-05T16:09:04Z

@isabelastisser we continued our work in the PR ^

isabelastisser · 2024-08-08T17:47:12Z

@tienifr @parasharrajat will the PR be merged soon?

parasharrajat · 2024-08-08T18:57:50Z

@isabelastisser PR is back in review.

isabelastisser · 2024-08-29T15:12:31Z

No updates yet, I see that we're still reviewing the PR.

isabelastisser · 2024-09-11T20:07:04Z

@parasharrajat, any news?

parasharrajat · 2024-09-11T20:08:31Z

PR awaiting Engineer review.

parasharrajat · 2024-09-21T18:55:07Z

It should be ready to be paid in 2 days.

isabelastisser · 2024-09-30T18:48:53Z

Payment summary:

$1000 to @parasharrajat for C+ review - payment pending in NewDot.
$1000 to @tienifr for accepted proposal - payment pending in NewDot.
$50 to @daveSeife for bug report - paid in Upwork.

isabelastisser · 2024-09-30T18:49:16Z

@parasharrajat, can you please confirm that the payment summary is correct? Thanks!

parasharrajat · 2024-10-03T19:47:43Z

@isabelastisser I think payment for @tienifr would be same as 1K.

parasharrajat · 2024-10-03T19:50:16Z

Payment requested as per #25892 (comment)

isabelastisser · 2024-10-04T20:31:52Z

@parasharrajat, do we need a regression test?

JmillsExpensify · 2024-10-05T10:56:11Z

Do we have a BZ checklist for this issue?

parasharrajat · 2024-10-05T10:59:20Z

I will add that soon. Please proceed with payment @JmillsExpensify

JmillsExpensify · 2024-10-05T11:00:40Z

Sorry I'm unable to, as that would fail our financial controls.

parasharrajat · 2024-10-05T13:55:36Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Fix focus after picking an emoji in edit mode #23258
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix focus after picking an emoji in edit mode #23258 (comment)
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Web & Desktop

Go to any chat
Switch a message to edit mode (A)
Click Emoji button of A, leave the modal open
Click main composer
Verify that main composer is focused

=====

Click A composer
Right click LHN item >> Mark as unread
Verify that A is focused
Right click another message >> Copy to clipboard
Verify that A is focused

=====

Switch another message to edit mode (B)
Click Emoji button of A >> Close the modal
Verify that A is focused
Repeat step 12-13 with B

=====

Click then Close B composer
Verify that main composer is focused

=====

Click A composer
Delete A from another device/browser
Right click another message >> Copy to clipboard
Verify that main composer is focused

mWeb & Android & iOS

Go to any chat
Switch a message to edit mode (A)
Verify main composer hides
Click Emoji button of A >> Close the modal
Verify that A is focused

=====

Right click a message >> Copy to clipboard
Verify that A is focused

=====

Switch another message to edit mode (B)
Click Emoji button of A >> Close the modal
mWeb & Android: Verify that A is focused
mWeb & Android: Repeat step 9-10 with B
iOS: Verify that B is focused

=====

Press then Close B composer
Verify main composer appears

=====

Click A composer
Delete A from another device/browser
Verify that main composer appears
Right click another message >> Copy to clipboard
mWeb: Verify that main composer is focused

Do you agree 👍 or 👎 ?

parasharrajat · 2024-10-05T13:56:56Z

@JmillsExpensify Done.

JmillsExpensify · 2024-10-05T17:47:20Z

Thanks! $1,000 approved for @parasharrajat

isabelastisser · 2024-10-07T12:54:40Z

@JmillsExpensify:

$1000 to @tienifr for accepted proposal - payment PENDING in NewDot.

isabelastisser · 2024-10-07T12:55:20Z

@johnmlee101, can you please review the test proposal when you have a chance? Thanks!

#25892 (comment)

johnmlee101 · 2024-10-07T15:04:47Z

LGTM!

isabelastisser · 2024-10-08T17:34:42Z

All set!

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 24, 2023

melvin-bot bot assigned MitchExpensify Aug 24, 2023

MitchExpensify added the External Added to denote the issue can be worked on by a contributor label Aug 25, 2023

melvin-bot bot changed the title ~~Chat - Composer Not focused when clicking on composer box~~ [$1000] Chat - Composer Not focused when clicking on composer box Aug 25, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 25, 2023

melvin-bot bot assigned parasharrajat Aug 25, 2023

melvin-bot bot added the Overdue label Aug 30, 2023

melvin-bot bot removed the Overdue label Aug 30, 2023

tienifr mentioned this issue Sep 5, 2023

Fix: Edit composer moves focus to main composer after press LHN menu item #24481

Merged

57 tasks

melvin-bot bot added the Overdue label Sep 6, 2023

melvin-bot bot removed the Overdue label Sep 6, 2023

melvin-bot bot added the Overdue label Sep 8, 2023

melvin-bot bot removed the Monthly KSv2 label Jul 16, 2024

parasharrajat mentioned this issue Oct 5, 2024

Fix focus after picking an emoji in edit mode #23258

Merged

79 tasks

isabelastisser closed this as completed Oct 8, 2024

[$1000] Chat - Composer Not focused when clicking on composer box #25892

[$1000] Chat - Composer Not focused when clicking on composer box #25892

Comments

lanitochka17 commented Aug 24, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Aug 24, 2023

melvin-bot bot commented Aug 24, 2023 • edited by MitchExpensify Loading

Bug0 Triage Checklist (Main S/O)

hoangzinh commented Aug 25, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot bot commented Aug 25, 2023

melvin-bot bot commented Aug 25, 2023

melvin-bot bot commented Aug 25, 2023

tienifr commented Aug 26, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

parasharrajat commented Aug 27, 2023

rojiphil commented Aug 28, 2023

parasharrajat commented Aug 28, 2023

MitchExpensify commented Aug 30, 2023

parasharrajat commented Aug 31, 2023

melvin-bot bot commented Sep 1, 2023

MitchExpensify commented Sep 3, 2023

tienifr commented Sep 6, 2023 • edited Loading

MitchExpensify commented Sep 6, 2023

melvin-bot bot commented Sep 8, 2023

isabelastisser commented Jul 18, 2024

tienifr commented Jul 22, 2024

parasharrajat commented Jul 22, 2024

parasharrajat commented Jul 31, 2024

isabelastisser commented Aug 5, 2024

tienifr commented Aug 5, 2024

isabelastisser commented Aug 8, 2024

parasharrajat commented Aug 8, 2024

isabelastisser commented Aug 29, 2024

isabelastisser commented Sep 11, 2024

parasharrajat commented Sep 11, 2024

parasharrajat commented Sep 21, 2024

isabelastisser commented Sep 30, 2024 • edited Loading

isabelastisser commented Sep 30, 2024

parasharrajat commented Oct 3, 2024 • edited Loading

parasharrajat commented Oct 3, 2024

isabelastisser commented Oct 4, 2024

JmillsExpensify commented Oct 5, 2024

parasharrajat commented Oct 5, 2024

JmillsExpensify commented Oct 5, 2024

parasharrajat commented Oct 5, 2024 • edited Loading

Regression Test Steps

Web & Desktop

mWeb & Android & iOS

parasharrajat commented Oct 5, 2024

JmillsExpensify commented Oct 5, 2024

isabelastisser commented Oct 7, 2024

isabelastisser commented Oct 7, 2024

johnmlee101 commented Oct 7, 2024

isabelastisser commented Oct 8, 2024

lanitochka17 commented Aug 24, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Aug 24, 2023 •

edited by MitchExpensify

Loading

hoangzinh commented Aug 25, 2023 •

edited

Loading

tienifr commented Aug 26, 2023 •

edited

Loading

tienifr commented Sep 6, 2023 •

edited

Loading

isabelastisser commented Sep 30, 2024 •

edited

Loading

parasharrajat commented Oct 3, 2024 •

edited

Loading

parasharrajat commented Oct 5, 2024 •

edited

Loading