Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-20] [TS migration] Migrate 'Tooltip' component to TypeScript #25123

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Not a priority Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/Tooltip/tooltipPropTypes.js 3
src/components/Tooltip/index.native.js 1
src/components/Tooltip/index.js 12
src/components/Tooltip/TooltipSense.js 2
src/components/Tooltip/TooltipRenderedOnPageBody.js 7
Issue OwnerCurrent Issue Owner: @isabelastisser
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 10, 2023
@kosmydel
Copy link
Contributor

Hey! I’m Jakub from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Dec 4, 2023
@allroundexperts
Copy link
Contributor

🎀 👀 🎀 Getting an internal engineer

Copy link
Author

melvin-bot bot commented Dec 7, 2023

Triggered auto assignment to @joelbettner, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mountiny mountiny added the NewFeature Something to build that is a new item. label Dec 8, 2023
Copy link
Author

melvin-bot bot commented Dec 8, 2023

@mountiny
Copy link
Contributor

mountiny commented Dec 8, 2023

Took this over as I was asked to get it merged soon due to high chance of merge conflicts

@isabelastisser $250 to @allroundexperts for testing and review

@isabelastisser
Copy link
Contributor

All set!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 13, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'Tooltip' component to TypeScript [HOLD for payment 2023-12-20] [TS migration] Migrate 'Tooltip' component to TypeScript Dec 13, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 13, 2023
Copy link
Author

melvin-bot bot commented Dec 13, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Dec 13, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Dec 13, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@JmillsExpensify
Copy link

$250 payment to @allroundexperts based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Not a priority Task Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests

7 participants