[HOLD for payment 2024-02-15] [$250] [TS migration] Migrate 'SettlementButton.js' component to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/SettlementButton.js	18

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018a41880e78febd6d
• Upwork Job ID: 1736777260313042944
• Last Price Increase: 2023-12-18
• Automatic offers:
• ZhenjaHorbach | Contributor | 28077235
• hoangzinh | Contributor | 28081224

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018a41880e78febd6d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[melvin-bot]

Upwork job price has been updated to $250

[ishpaul777]

i would love to take it

[KrAbhas]

I would like to work on this

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[TS migration] Migrate 'SettlementButton.js' component to TypeScript

What is the root cause of that problem?

Not problem (Technical ticket )

What changes do you think we should make in order to solve the problem?

We need to update this file using best practices using TS guide

https://github.com/Expensify/App/blob/main/contributingGuides/TS_STYLE.md

What alternative solutions did you explore? (Optional)

NA

[rayane-djouah]

I would like to work on this issue

[narefyev91]

@ZhenjaHorbach is the first to #25100 (comment) with no other TS issue assigned.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[yh-0218]

I would like to work on this issue

[hoangzinh]

@AndrewGable @mountiny Melvin auto-assigned me to review the PR #33866. I can take over from @narefyev91 as C+ if needed.

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Triggered auto assignment to @twisterdotcom (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[mountiny]

Yep thanks

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

This issue has not been updated in over 15 days. @AndrewGable, @twisterdotcom, @hoangzinh, @ZhenjaHorbach eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[twisterdotcom]

The PR was merged two hours ago: #33866

I'll need to pay out @hoangzinh when it's deployed. Hopefully the title changes.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Migrate 'SettlementButton.js' component to TypeScript #33866
• [TS migration] Migrate 'SettlementButton.js' component to TypeScript PART-2 #35877

If no regressions arise, payment will be issued on 2024-02-15. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment automatic offer (Contributor)
• @ZhenjaHorbach requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[twisterdotcom]

No need for regression tests, this is a TS migration.

[twisterdotcom]

Payment summary:

• @hoangzinh paid $250 here (Contributor)
• @ZhenjaHorbach paid $250 here (Contributor)