Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: Expensify.cash 2021-04-08 #2310

Closed
5 tasks done
OSBotify opened this issue Apr 8, 2021 · 5 comments
Closed
5 tasks done

Deploy Checklist: Expensify.cash 2021-04-08 #2310

OSBotify opened this issue Apr 8, 2021 · 5 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Apr 8, 2021 •
edited by isagoico
Loading

Release Version: 1.0.18-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

cc @Expensify/applauseleads
@isagoico isagoico added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 9, 2021
@isagoico
Copy link

isagoico commented Apr 9, 2021 •
edited
Loading

Regression is finished.
2 issues found today:

  1. mWeb / Web - Transitions are not smooth when creating a chat or opening a conversation #2328
  2. Web - Chat- Loading spinner displayed on login in conversation screen #2327

PRs are finished too.
1 comment added:

  1. Added transition handling between the side drawer and chats #2221 (comment) (PR was a pass except in Web, but we found the issue mentioned in the comment, not marking as deploy blocker since it's repro in prod)

Thanks!

@isagoico isagoico closed this as completed Apr 9, 2021
@OSBotify
Copy link
Contributor Author

OSBotify commented Apr 9, 2021

This issue either has unchecked QA steps or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@OSBotify OSBotify reopened this Apr 9, 2021
@isagoico
Copy link

isagoico commented Apr 9, 2021

Let's go! :shipit:

@isagoico isagoico closed this as completed Apr 9, 2021
@OSBotify
Copy link
Contributor Author

OSBotify commented Apr 9, 2021

This issue either has unchecked QA steps or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@OSBotify OSBotify reopened this Apr 9, 2021
@isagoico
Copy link

isagoico commented Apr 9, 2021

:shipit:

@isagoico isagoico closed this as completed Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@applausebot @isagoico @OSBotify