[HOLD for payment 2023-08-21] [HOLD for payment 2023-07-26] [$2000] mWeb - Thread - Chat header jumps if swipe away from thread

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App on mWeb safari
2. Open a chat
3. Long press a message in chat that doesn't have a thread
4. Tap "Reply in thread" (make sure that the keyboard is visible if you are using simulator, cmd + K)
5. Swipe thread screen to the right to close it and land in chat

Expected Result:

The layout should be consistent

Actual Result:

The layout glitches , Chat header jumps to middles of screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.31-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-26.at.8.09.53.PM.mov

RPReplay_Final1687986996.MP4

Expensify/Expensify Issue URL:
Issue reported by: @fedirjh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687902430669059

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015ac36e87f5779232
• Upwork Job ID: 1674609086791106560
• Last Price Increase: 2023-07-06

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[fedirjh]

cc @amyevans @adamgrzybowski

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[alexpensify]

Reassigning another bug team member, I'm going OOO until Monday, July 10, and will take it back if it's still open by my return date.

Required action from the 🐛 team: I've run out of time and haven't tested this one yet. This GH needs testing to confirm if it's a bug, check if it's a dupe, and then assign the applicable labels. Thank you!

[sophiepintoraetz]

I'm able to replicate this!
https://github.com/Expensify/App/assets/42940078/4969dff5-8f6a-4d4b-b996-5c359f83c077

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015ac36e87f5779232

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[sophiepintoraetz]

@fedirjh - did @amyevans and @adamgrzybowski work on the PR that caused this (regression)?

[fedirjh]

@sophiepintoraetz No it's not a regression, it's a bug that we found during reviewing this PR #21124 , more more context here

[sophiepintoraetz]

Still waiting on proposals - @adamgrzybowski, did you have an idea here?

[adamgrzybowski]

I am currently working on other tasks so I haven't thought about this too much

[sophiepintoraetz]

All right - I'll doubling the price to get more traction - otherwise dropping it into an external agency.

[melvin-bot]

Upwork job price has been updated to $2000

[sophiepintoraetz]

Hey @alexpensify! I think you're back in office today so I'll hand this one back over to you. In short, I've been able to replicate it but haven't found a contributor, so dropped it into software mansion. If that comes up with nothing, next step was to go to call stack!

[allroundexperts]

@alexpensify The PR still has some pending changes.

[alexpensify]

Got it! Thanks for flagging to hold on the payment process.

[alexpensify]

@allroundexperts - can you please clarify if this PR is related to regression or something else found in the review process?

[allroundexperts]

@allroundexperts - can you please clarify if this PR is related to regression or something else found in the review process?

It's a regression.

[alexpensify]

Ok, thank you for this update @allroundexperts!

[alexpensify]

The PR for regression is still under review

[alexpensify]

No update, the PR is still under review

[alexpensify]

The regression PR is still under review

[alexpensify]

No update

[alexpensify]

Ok, it looks like the PR merged. We will give it a week to confirm no new issues. Let me know if there are any questions about that plan.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• 21843 - mWeb - Thread - Chat header jumps if swipe away from thread #23186

If no regressions arise, payment will be issued on 2023-08-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligable for Manual Requests)
• @robertKozik does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts / @robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts / @robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts / @robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts / @robertKozik] Determine if we should create a regression test for this bug.
• [@allroundexperts / @robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

@allroundexperts when you get a chance can you please fill out the checklist? Thanks!

[alexpensify]

@aldo-expensify - is everything completed here (no more PRs or regressions) and I can prepare for the August 21 payment date? Thanks!

[aldo-expensify]

@aldo-expensify - is everything completed here (no more PRs or regressions) and I can prepare for the August 21 payment date? Thanks!

I think that is correct, I didn't find mentions of the PR causing a regression.

[aldo-expensify]

@allroundexperts friendly bump on the checklist: #21843 (comment)

[allroundexperts]

Checklist

1. This issue surfaced after threads were introduced. There isn't a single PR which I could point to.
2. N/A
3. I can not think of a checklist addition which could have avoided this. As such, a slack discussion might not be needed here. During the testing of threads, we could have caught this by QAing it more. But still, I think this is really minor.
4. This is a visual bug that is platform specific (iOS and Android). I don't think we need a regression test here.

[alexpensify]

Thank you for these updates, I'll work on the payment process tomorrow.

[alexpensify]

Here is the payment summary:

• External issue reporter @fedirjh $250
• Contributor that fixed the issue @robertKozik payment handled via SM
• Contributor+ that helped on the issue and/or PR @allroundexperts $1000

Upwork Job: https://www.upwork.com/jobs/~015ac36e87f5779232

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: From CONTRIBUTING.md, each regression reduces the pay amount for C and C+ by 50%. For this GH, the base rate was $2000. Taking into account 1 regression, the payment amount here will be $1000 and there is no urgency bonus.

[alexpensify]

@fedirjh - please accept the payment in Upwork. Thanks!

[alexpensify]

I've completed the payments in Upwork and closed the job.

Closing this GH

[JmillsExpensify]

Reviewed the details for @allroundexperts. $1,000 approved for payment in NewDot based on the BZ summary above.