[HOLD for payment 2023-07-10] [$1000] Deleting workspace in connect bank account provides update currency error

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app and login with user A (device 1)
2. Open the app in another device and login with user A (device 2)
3. In device 1, open settings->workspaces->any workspace->Bank account->Connect manually->Complete step 1 (eg data: routing= 210021002, acc no = 1234) > DO NOT CLICK SAVE
4. From device 2, open settings->workspaces->open workspace opened in step 3->Click on 3 dots and delete the workspace
5. Observe the error in device 1

Expected Result:

App should display 'Hmm its not here' page when workspace is deleted

Actual Result:

App displays error:

"Oops! It appears that your workspace currency is set to a different currency than USD. To proceed, please set it to USD and try again"

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.3.2-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.5168.mp4

delete.workspace.displays.update.USD.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687340354605359

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b7395caefe5a942e
• Upwork Job ID: 1673414242053304320
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deleting workspace from second tab gives update currency error in first tab

What is the root cause of that problem?

In the ReimbursementAccountPage we are not checking whether policy is available or not and based on that we are not showing any not found page.

What changes do you think we should make in order to solve the problem?

We should validate the policy and if it is empty we should return early with the notFound page(we can use more props of FullPageNotFoundView for more customization).
https://github.com/Expensify/App/blob/a77d74ba7bb6d998e52b81e24f482123e96e7222/src/pages/ReimbursementAccount/ReimbursementAccountPage.js#L333C1-L333C1

       if(_.isEmpty(this.props.policy)) {
            return (
                <FullPageNotFoundView shouldShow />
            )
        }

[Christinadobrzyn]

I can reproduce - adding engineering and External

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b7395caefe5a942e

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[puneetlath]

@Christinadobrzyn you only need to add the External label. An engineer will be auto-assigned once the C+ selects a proposal.

[fedirjh]

@Pujan92 Proposal's make sense to me , I think we need to use <NotFoundPage /> instead because it should be wrapped in ScreenWrapper and I would suggest to remove the extra FullPageNotFoundView from ContinueBankAccountSetup for consistency as it will be handled in one place , ReimbursementAccountPage.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @Pujan92 You have been assigned to this job by @grgia!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Pujan92]

@fedirjh @grgia PR is ready for review!

[melvin-bot]

🎯 ⚡️ Woah @fedirjh / @Pujan92, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @Pujan92 got assigned: 2023-06-28 12:41:53 Z
• when the PR got merged: 2023-06-29 15:47:35 UTC

On to the next one 🚀

[Christinadobrzyn]

Hired in Upwork:
Internal job posting: https://www.upwork.com/ab/applicants/1673414242053304320/job-details
External job posting: https://www.upwork.com/jobs/~01b7395caefe5a942e

@dhanashree-sawant as reporter
@Pujan92 as contributor
@fedirjh as C+

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.35-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Deleting workspace in connect bank account provides update currency error #21819

If no regressions arise, payment will be issued on 2023-07-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

Do we need a regression test for this? @fedirjh?

[fedirjh]

• Link to the PR: Ask non-USD Workspaces to update currency before adding VBBA #19638
• Link to comment: Ask non-USD Workspaces to update currency before adding VBBA #19638 (comment)
• Link to discussion: N/A , This is an extremely edge case, there’s nothing to add to checklist.

Do we need a regression test for this?

@Christinadobrzyn This is an example of an edged case, we don’t need a regression test.

[Christinadobrzyn]

Paid! in Upwork with a bonus based on #21604 (comment)

Closed job in Upwork and closing this GH.