[HOLD for payment 2023-07-14] [$1000] The workspace logo disappears if changed the workspace picture on combined user/workspace chat

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to dev on web chrome
2. Create a new workspace and invite a user
3. Notice that on LHN, a combined workspace and user chat is created with both the user picture and the workspace picture
4. Now try to change the workspace picture and notice that as soon as you change the workspace picture, the logo of the workspace that was present below in the LHN chat disappears. And if you remove the workspace picture, it reappears again
5. Thus, it should have shown the updated picture on the LHN , instead of making it disappear

Expected Result:

The workspace logo should have been updated to the picture set on the LHN in the combined user/workspace chat instead of making it go disappear

Actual Result:

The workspace logo disappears if changed the workspace picture on combined user/workspace chat

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.21-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

chat-2023-05-29_11.26.13.mp4

Recording.825.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685339400060349

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018e5f5da305633aff
• Upwork Job ID: 1669420216317644800
• Last Price Increase: 2023-06-15

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace icon does not update in the workspace chat

What is the root cause of that problem?

The root cause of the issue is that we're not re-rendering the component once the avatar property gets updated in the Policy object in the ReportActionItemCreated component.

What changes do you think we should make in order to solve the problem?

Firstly, we need to pass policyID prop into ReportActionItemCreated component here.

Next, we'll need to load the policy into the ReportActionItemCreated component as a prop. We need to add following here.

 policy: {
            key: ({policyID}) => `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
        },

This will re-render the component and call const icons = ReportUtils.getIcons(props.report, props.personalDetails) function whenever the attached policy changes ie any avatar is added / removed from it.

We can optimise this approach further by just re-rendering when the avatar property of the attached policy changes.

What alternative solutions did you explore? (Optional)

None

[strepanier03]

This should be fixed with #19750 so I'm going to put it on hold until that is merged so we can test again to be sure.

[strepanier03]

PR has been deployed to Prod so I'm going to ask for someone to test again and then I'll action as necessary.

[strepanier03]

I don't have a dev environment so I asked here if someone could test for me.

[strepanier03]

Switching to Daily for now so I can remember to revisit this tomorrow.

[priya-zha]

#19750 was fixed, but this issue still exists. I just tested it today again.

error-2023-06-14_17.25.10.online-video-cutter.com.mp4

[strepanier03]

This is still happening on DEV so I'm going to remove the hold and push through the BZ process so we can get a re-evaluation of it.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018e5f5da305633aff

[melvin-bot]

Triggered auto assignment to @tjferriss (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @NikkiWines (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[NikkiWines]

@rushatgabhane friendly bump here 🙇

[tjferriss]

Payments sent to @developerdavi and @priya-zha

[tjferriss]

@rushatgabhane can you accept the offer in Upworks?

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: UI MoneyRequestHeader Polish #18775

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18775/files#r1271469115

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again N.A.

[rushatgabhane]

Hi @tjferriss thanks for the offer on upwork but I'll be requesting payment on new dot.
Anu will handle new dot payments for now.

[rushatgabhane]

Made a manual request on new dot https://staging.new.expensify.com/r/4385861037826843

[tjferriss]

Easy, Melvin. We're just wrapping up payment.

[parasharrajat]

Found a regression from this issue's PR #22467 (comment). I need some assistance determine the correct solution. https://github.com/Expensify/App/pull/21657/files#r1275373499

[JmillsExpensify]

@tjferriss Can you please summarize the appropriate individual payments for all parties involved in this issue? This is holding up @rushatgabhane's NewDot payments. More information on this compliance process in Slack. This may also be affected based on the possible regression above.

[tjferriss]

The payment comment has been updated: #19905 (comment)

[parasharrajat]

@rushatgabhane Please respond to #19905 (comment) when you have time. Thanks.

[JmillsExpensify]

Reviewed details for @rushatgabhane. This is accurate based on summary from Business Reviewer and approved for payment in NewDot.

[melvin-bot]

@tjferriss, @NikkiWines, @rushatgabhane, @developerdavi Eep! 4 days overdue now. Issues have feelings too...

[tjferriss]

@rushatgabhane bumping this comment once more #19905 (comment)

[rushatgabhane]

@tjferriss i had responded to the in the PR https://github.com/Expensify/App/pull/21657/files#r1277398010

sorry for no updates on issue. we can close this i think