-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1000] Welcome message modal doest not have back button #19903
Comments
Triggered auto assignment to @adelekennedy ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.In this issue, we can notice that on the Set a welcome message page, the back button is not present in the header. What is the root cause of that problem?To display the back button, we use the What changes do you think we should make in order to solve the problem?To fix this issue, we need to pass the prop What alternative solutions did you explore? (Optional)None |
ProposalPlease re-state the problem that we are trying to solve in this issue.Welcome message modal doest not have back button. What is the root cause of that problem?The App/src/pages/ReportWelcomeMessagePage.js Lines 60 to 64 in 12d2f3c
What changes do you think we should make in order to solve the problem?add prop What alternative solutions did you explore? (Optional) |
Is this up for grabs? |
📣 @GItGudRatio! 📣
|
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
ProposalPlease re-state the problem that we are trying to solve in this issue.Welcome message modal doest not have back button What is the root cause of that problem?App/src/pages/ReportWelcomeMessagePage.js Lines 60 to 64 in 414dc10
in ReportWelcomeMessagePage we don't add shouldShowBackButton props to display Back button
What changes do you think we should make in order to solve the problem?Adding
Result |
Looks like something related to As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our Feel free to drop a note in #expensify-open-source with any questions. |
can reproduce! this is a clear bug |
Job added to Upwork: https://www.upwork.com/jobs/~01dabd1979b66a6a86 |
Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat ( |
Triggered auto assignment to @roryabraham ( |
@Prince-Mendiratta 's proposal looks good to me. cc: @roryabraham 🎀 👀 🎀 C+ reviewed |
📣 @Prince-Mendiratta You have been assigned to this job by @roryabraham! |
Thanks @Prince-Mendiratta @parasharrajat 🙇🏼 |
@roryabraham @parasharrajat This PR was just merged yesterday, which ended up fixing this issue. How should we proceed now? |
I see. @adelekennedy What is the next step here? There is no PR required now. |
I think we should pay out @Prince-Mendiratta for their time and then close this out since it's not going to be needed anymore. |
@parasharrajat, @roryabraham, @Prince-Mendiratta, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@Prince-Mendiratta just sent you an offer on Upwork! |
@adelekennedy am i eligible for reporting bonus? |
@ayazhussain79 Sorry, the reporting bonus is only paid out when an issue is fixed, and this isn't fixed quite yet. |
Payment requested as per https://expensify.slack.com/archives/C02NK2DQWUX/p1686903062857739 |
@adelekennedy Can you please summarize the appropriate individual payments for all parties involved in this issue? This is holding up @parasharrajat NewDot payments. More information on this compliance process in Slack. |
Here is the payment summary: External issue reporter: @ayazhussain79 $250 Extra Notes regarding payment: |
@adelekennedy offer accepted, Thank you |
Quoting a comment @adelekennedy from #19903 (comment) for visibility.
|
what if a PR fixed this issue after i reported so why reporter is not eligible for reporting bonus |
Reviewed details for @parasharrajat. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
1.Go to the chat
2.Send a message to user
3.Click on "Reply in thread"
4.Click on thread header > Settings > Welcome message
Expected Result:
Welcome message modal/popup should have back button
Actual Result:
Welcome message modal doest not have back button
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.21-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
20230529010305.mp4
az_recorder_20230531_142218.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685304337659739
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: