[HOLD] [$1000] mWeb - Contact gets highlighted on long press

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Tap on the search icon
2. Long press on a contact just after the page opens

Expected Result:

It shouldn't get highlighted

Actual Result:

The contact gets highlighted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19.2

Reproducible in staging?: n/a

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

video_20230525_164732_edit.mp4

Expensify/Expensify Issue URL:

Issue reported by: @thesahindia

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685013467217839

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01458f36110327280c
• Upwork Job ID: 1663571956217389056
• Last Price Increase: 2023-06-06

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01458f36110327280c

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[kushu7]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Contact gets highlighted on long press

What is the root cause of that problem?

On touch devices, long press sometimes fire hover event. its default behaviour can easily replicate and its not related to only search screen.

bug video

bug720p.mov

What changes do you think we should make in order to solve the problem?

We can prevent it by checking DeviceCapabilities.hasHoverSupport()

App/src/components/Hoverable/index.js

Lines 58 to 60 in 24381ed

	const child = _.isFunction(this.props.children)
	? this.props.children(this.state.isHovered)
	: this.props.children

We have two options.

1. We can simply add this condition here.

// should allow hover only when device hasHoverSupport capability.
const isHovered = DeviceCapabilities.hasHoverSupport() && this.state.isHovered;
const child = _.isFunction(this.props.children) ? this.props.children(isHovered) : this.props.children;

2. We can return children same as index.native.js

render() {
    if(!DeviceCapabilities.hasHoverSupport()) {
    const childrenWithHoverState = _.isFunction(props.children) ? props.children(false) : props.children;
    return <View style={props.containerStyles}>{childrenWithHoverState}</View>;
    }
    .....
}

both will solve our problem globally.

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

@puneetlath, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

[puneetlath]

@Santhosh-Sellavel thoughts on the proposal?

[Santhosh-Sellavel]

@kushu7's proposal Looks good to me! @puneetlath

[puneetlath]

Looks to me like @kushu7 offered two different options. @kushu7 which do you prefer and why?

[kushu7]

Looks to me like @kushu7 offered two different options. @kushu7 which do you prefer and why?

I prefer 2nd option, in this we can skip unnecessary function callbacks that are related to hovering.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Santhosh-Sellavel]

Looks to me like @kushu7 offered two different options. @kushu7 which do you prefer and why?

I prefer 2nd option, in this we can skip unnecessary function callbacks that are related to hovering.

@puneetlath Sorry Yeah 2nd option looks good to me!

[kushu7]

Any update?
cc @puneetlath @Santhosh-Sellavel

[melvin-bot]

📣 @kushu7 You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Santhosh-Sellavel]

Thanks, @amyevans!

[Santhosh-Sellavel]

@abekkala Sorry for the delay. Can you add a hold to the issue title for issue #20585?

[Santhosh-Sellavel]

@abekkala we need to add a hold to this issue. Sorry for not being clear, test the PR is blocked by a regression. And it is being worked on the other issue #20585. So we need to hold this until the other PR is merged.

[abekkala]

Ah ok - got it!

[puneetlath]

@Santhosh-Sellavel it looks like #20585 is done. Does this still need to be held?

[Santhosh-Sellavel]

@puneetlath This issue is what we discussed yesterday!

[puneetlath]

@Santhosh-Sellavel @kushu7 it looks like this was made obsolete by another PR. However, since you were hired and already did the work, we'll still go ahead and pay you out (no bonus) for the effort.

I'll go ahead and close the PR and I've sent you both hiring offers. Ping me here once you've accepted and I'll pay them out. Thanks for the hard work!

[puneetlath]

Alright. @Santhosh-Sellavel will be paid via this. @kushu7 has been paid via Upwork.

Thanks everyone!

[thesahindia]

Hey @puneetlath, I think it is eligible for the reporting compensation.

[puneetlath]

@thesahindia sorry about that. Sent you an offer.

@Santhosh-Sellavel do you need me to leave the issue open for tracking your payment? Or am I good to close once I pay sahil?

[Santhosh-Sellavel]

Let's just keep it open till next week, if it's not affecting anything!

[puneetlath]

Ok sounds good.

@thesahindia please accept the contract when you have a chance.

[thesahindia]

Accepted, thanks!

[puneetlath]

Ok, @thesahindia has been paid. So we can close this once @Santhosh-Sellavel has confirmed he's been paid via Expensify.

[puneetlath]

@Santhosh-Sellavel did you receive payment yet?

[puneetlath]

Everyone has been paid. Closing!