[HOLD for payment 2023-05-23] [$1000] IOUPreview height should adjust based on content

[Julesssss]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create an iou request to any user without adding a comment
2. Settle the IOU
3. Create an iou request to any user without adding a comment
4. Settle the IOU

Expected Result:

• The Card heights should be different

Actual Result:

• The card heights are the same
• The card without a description has a large gap where the comment would have shown

Native mobile

Web

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.13-0
Issue reported by: @thesahindia here

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d6ca19ff51a2559a
• Upwork Job ID: 1656655701807489024
• Last Price Increase: 2023-05-11

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[huzaifa-99]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want the IOUPreview to adjust its height based on content, specifically if it has a comment/description

What is the root cause of that problem?

The <Text> element for comment/description here is rendering always, regardless if there is any comment/description

What changes do you think we should make in order to solve the problem?

We should conditionally render the <Text> component that displays comment/description here by first calculating description/value like this

const requestDescription = Str.htmlDecode(lodashGet(props.action, 'originalMessage.comment', ''))

and then render it like so

{requestDescription && <Text>{requestDescription}</Text>}

Result

What alternative solutions did you explore? (Optional)

N/A

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOUPreview height does not adjust based on comment

What is the root cause of that problem?

The root cause is that we're always rendering the Text here.

What changes do you think we should make in order to solve the problem?

We should render the text only if a comment exists for IOU. This gets replaced with:

// This can be saved in a variable as well
{lodashGet(props.action, 'originalMessage.comment', '') ? <Text style={[styles.colorMuted]}>{Str.htmlDecode(lodashGet(props.action, 'originalMessage.comment', ''))}</Text> : null}

Using && condition above will cause this regression. We should be using ternary instead.

Although not strictly required, we can also convert this and this into ternary expressions as well.

What alternative solutions did you explore? (Optional)

None

[Julesssss]

thanks both. This is pretty straight forward so I'm going with the first passable proposal (#18770 (comment)). Also creating requestDescription on a separate line is a bit more readable.

[Julesssss]

@huzaifa-99 feel free to make a start on the PR, I'll assign you once the UpWork job has been created 👍

[Julesssss]

Actually I don't think anything will break if I do this now

[Julesssss]

Okay nevermind, that didn't trigger the automation, I'll do that again once Ted gets a chance to review.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d6ca19ff51a2559a

[melvin-bot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[huzaifa-99]

Thanks for the proposal review @Julesssss.

pull/18774 is ready!

[melvin-bot]

📣 @huzaifa-99 You have been assigned to this job by @Julesssss!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[trjExpensify]

Yup! Done!

[mountiny]

Merged

[trjExpensify]

Strange, this should have got the reviewing label. PR is on staging. 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Adjust IOUPreview height based on description availability #18774

If no regressions arise, payment will be issued on 2023-05-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[huzaifa-99]

Payment still pending guys 😄!

[mountiny]

@trjExpensify was ooo but should be back today, sorry about that

[huzaifa-99]

no worries @mountiny. Thank you!

[Julesssss]

The issue will remain open until paid, and Tom will be back soon :)

[trjExpensify]

Yuuup, I got back today. 👍 Looking at this now, appreciate the patience.

[aimane-chnaif]

No PR caused regression. This is more like polish than bug and found during PR review here.
So no need regression test step.

[trjExpensify]

Yup, this was when adding a new feature. Regression tests will be updated more broadly for the manual requests redesign.

[trjExpensify]

Okay, so my assessment for payments is as follows:

@aimane-chnaif - $1,500 for the C+ review & #urgency bonus
@huzaifa-99 - $1,500 for the fix & #urgency bonus
@thesahindia - $250 for reporting the bug in this PR

Does that sound right to everyone?

[trjExpensify]

Offers have been sent to all three of you in the meantime.

[huzaifa-99]

Thank you @trjExpensify. Accepted!

[trjExpensify]

Settled up with @huzaifa-99 & @aimane-chnaif. Awaiting @thesahindia and then I'll close this out.

Job ref for ease.

[thesahindia]

Accepted, thanks!

[trjExpensify]

Awesome, settled. Closing!