[HOLD for payment 2023-05-16] [$1000] No hover effect on Amount and Description fields on new send money page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click on plus and click on send money
3. Enter any amount and click continue
4. Select any person and click continue
5. Hover on Amount and Description fields and observe that there is no hover effect

Expected Result:

On hover on Amount and Description fields, app should change background color to rgb(26,61,50) and arrow color should change to rgb(231,236,233) as it does on all the similar fields throughout the app

Actual Result:

App has no hover effect on hover on Amount and Description fields

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

no.hover.effect.on.new.fields.mp4

Recording.276.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681810766206009

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012282950dc9ac5e8a
• Upwork Job ID: 1651189202939957248
• Last Price Increase: 2023-04-26

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• No hover effect on Amount and Description fields on new send money page

What is the root cause of that problem?

• This was recently refactor to add push to page components with that we interactive default to false that will make component not to add background colour on hour 

  What changes do you think we should make in order to solve the problem?

• We just need to remove interactive props or make interactive -> true 

  Changes

<MenuItemWithTopDescription
                   shouldShowRightIcon
                   title={formattedAmount}
                   description={this.props.translate('iou.amount')}
-                    interactive={false} // This is so the menu item's background doesn't change color on hover
                   onPress={() => this.props.navigateToStep(0)}
                   style={styles.moneyRequestMenuItem}
                   titleStyle={styles.moneyRequestConfirmationAmount}
               />
               <MenuItemWithTopDescription
                   shouldShowRightIcon
                   title={this.props.iou.comment}
                   description={this.props.translate('common.description')}
-                    interactive={false} // This is so the menu item's background doesn't change color on hover
                   onPress={() => Navigation.navigate(ROUTES.MONEY_REQUEST_DESCRIPTION)}
                   style={styles.moneyRequestMenuItem}
               />

Adding proposal before help label as per new guid line

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[Prince-Mendiratta]

Looks intentional, #16919 (comment).

@shawnborton what are your thoughts on this?

[shawnborton]

Interesting, I guess we should keep them consistent so I would say we should add the hover effect.

[Prince-Mendiratta]

@shawnborton I wonder why this was originally implemented to remove the hover effect. Are the future design looking for removing the hover effect on Menu Items?

[dhairyasenjaliya]

I think we should add hover effect since we are using same MenuItem components as used other which has hover effect

[shawnborton]

Hmm yeah, @yuwenmemon is there more context as for why we removed the hover effect from those rows? cc @cristipaval who's worked on these push rows in other contexts too.

I think my vote would be to treat them consistently everywhere. I am fine with the background color changing, or we could do something more subtle and only change the hover color of the right arrow?

[MelvinBot]

@michaelhaxhiu Eep! 4 days overdue now. Issues have feelings too...

[michaelhaxhiu]

I think my vote would be to treat them consistently everywhere.

Same, consistency is the goal. If there wasn't a (very) good reason to have this behave inconsistently, we should fix it now and keep it that way going forward.

[michaelhaxhiu]

Pinging slack thread to make sure Yuwen gets an eye on this... I want to label external ASAP if we agree to fix this one.

I'm just trying to make sure I'm not missing sight of something key here cc @yuwenmemon

[yuwenmemon]

@shawnborton never even thought about hovering there. Let's add it in!

[Prince-Mendiratta]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In this issue, we can notice that the menu items "Amount" and "Description" on the Money Request/Send/Split flows do not have a hover effect.

What is the root cause of that problem?

The root cause behind this issue is because of two factors.
Lack of the hover effect
The interactive prop is set to false, which disables the hover effect.

Weird hover effect if enabled
The reason I believe the hover effect was disabled originally is because the MenuItemWithTopDescription for the "Amount" and "Description" are passed as children to the OptionsSelector. For any children passed to the OptionsSelector, the parent adds a view with padding and adds the passed components as children to it. With the hover effect enabled, it is added only to the child, causing the hover effect to show up not on the parent view which causes inconsistent effect.

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 326 to 336 in f3fae40

	this.props.shouldTextInputAppearBelowOptions
	? (
	<>
	<View style={[styles.flexGrow0, styles.flexShrink1, styles.flexBasisAuto, styles.w100, styles.flexRow]}>
	{optionsList}
	</View>
	<View style={[styles.ph5, styles.pv5, styles.flexGrow1, styles.flexShrink0]}>
	{this.props.children}
	{this.props.shouldShowTextInput && textInput}
	</View>
	</>

What changes do you think we should make in order to solve the problem?

In order to fix this and add the hover effect in a consistent manner to other menu items, we will have to make the following changes:

1. Get rid of the interactive prop.
2. Add a new prop to OptionsSelector and modify the prop types accordingly with a default value of true that will determine if the styles should be rendered in the parent view. This can be achieved using the statement this.props.shouldUseStyleForChildren && [styles.ph5, styles.pv5, styles.flexGrow1, styles.flexShrink0].
3. We need to pass this prop to the OptionsSelector in the MoneyRequestConfirmationList with value false.
4. We need to modify the moneyRequestMenuItem style to have horizontal padding set to 20 and vertical padding set to 20.

Additionally, we need to modify the padding and margin according to the needs but that can be tackled in the PR review.

What alternative solutions did you explore? (Optional)

None

Results

2023-04-26.12-00-38.mp4

[shawnborton]

That looks good to me @Prince-Mendiratta

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~012282950dc9ac5e8a

[MelvinBot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[MelvinBot]

📣 @Prince-Mendiratta You have been assigned to this job by @marcochavezf!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Prince-Mendiratta]

PR is up for review!

Applied in upwork.

cc @aimane-chnaif @marcochavezf @shawnborton @michaelhaxhiu

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [MoneyRequestConfirmation] add hover style to fields on the money confirmation modal #18347

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - @dhanashree-sawant $250
• Contributor that fixed the issue - @Prince-Mendiratta $1500
• Contributor+ that helped on the issue and/or PR - @aimane-chnaif $1500

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Prince-Mendiratta]

Sharing the timeline of this issue to help with the eventual analysis, calculated with this tool.

🐛 Issue created at: Tue, 18 Apr 2023 21:10:01 GMT
🧯 Help Wanted at: Wed, 26 Apr 2023 11:39:37 GMT
🕵🏻 Contributor assigned at: Wed, 03 May 2023 15:48:11 GMT
🛸 PR created at: Wed, 03 May 2023 16:31:30 GMT
🎯 PR merged at: Thu, 04 May 2023 15:36:27 GMT
⌛ Business Days Elapsed between assignment and PR merge: 1

[michaelhaxhiu]

https://www.upwork.com/jobs/~012282950dc9ac5e8a

Invited the C, C+, and Bug reporter to the Upwork job.

[michaelhaxhiu]

Payouts will be 50% increased based on turnaround time. I added those amounts to the checklist here #17635 (comment)

[michaelhaxhiu]

@aimane-chnaif can you fill out the checklist posted last week so that we ensure this can be paid / closed?

[aimane-chnaif]

• The PR that introduced the bug has been identified. Link to the PR: Add Push-to-Page support for IOUConfirmationList #16919
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add Push-to-Page support for IOUConfirmationList #16919 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This was already known and intentional to prevent ugly styles so no further discussions needed.

@michaelhaxhiu do you think it's worth to add something like below to checklist? If not, no regression test step needed.

• If new push-to-page was implemented, I verified that items have hoverable effects and right arrow icon at the right edge.

[michaelhaxhiu]

@isagoico do you think this QA test is worthwhile?

[isagoico]

@michaelhaxhiu I don't think this is a big feature that should be tested on every regression run. Looks like a good candidate for Edge case testing. Will add it to our edge case list and will be tested on a monthly basis.

[michaelhaxhiu]

Sweet - do I need to make a GH for that @isagoico ?

[michaelhaxhiu]

spoke via DM and nope, Isa has got it!

[michaelhaxhiu]

All paid. Closing.