Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-29] [HOLD] [$250] Migrate WorkspaceMembersPage.js to function component #16306

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement.

Comments

@marcaaron
Copy link
Contributor

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate WorkspaceMembersPage.js to function component [HOLD] [$250] Migrate WorkspaceMembersPage.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@muxriddinmuqimov77
Copy link

I can work on this issue when it goes to external

@Li357 Li357 self-assigned this Jun 6, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jun 14, 2023
@abdulrahuman5196
Copy link
Contributor

@Li357 Kindly assign me and BZ for C+ review processing.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Jun 22, 2023
@melvin-bot melvin-bot bot changed the title [HOLD] [$250] Migrate WorkspaceMembersPage.js to function component [HOLD for payment 2023-06-29] [HOLD] [$250] Migrate WorkspaceMembersPage.js to function component Jun 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@abdulrahuman5196
Copy link
Contributor

@Li357 Gentle ping on this #16306 (comment)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 28, 2023
@abdulrahuman5196
Copy link
Contributor

@Li357 Could you kindly assign the label to assign a BZ on this issue to process payment?

@Li357 Li357 added the Bug Something is broken. Auto assigns a BugZero manager. label Jun 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 29, 2023

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 29, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@abdulrahuman5196
Copy link
Contributor

No BZ Checklist. We are only doing migration to function component

@kevinksullivan
Copy link
Contributor

@abdulrahuman5196 can you apply to this job and let me know wen you've done so?

https://www.upwork.com/jobs/~018a5ff86cf2e66e2c

@melvin-bot melvin-bot bot added the Overdue label Jul 3, 2023
@Li357
Copy link
Contributor

Li357 commented Jul 3, 2023

Not overdue, waiting for Upwork application

@melvin-bot melvin-bot bot removed the Overdue label Jul 3, 2023
@abdulrahuman5196
Copy link
Contributor

@kevinksullivan thank you. Submitted a proposal on the job.

@kevinksullivan
Copy link
Contributor

Thanks @abdulrahuman5196 . One final step on your part is accepting the offer. Let me know when you've done so an I'll wrap this up.

@abdulrahuman5196
Copy link
Contributor

abdulrahuman5196 commented Jul 4, 2023

@kevinksullivan thank you. accepted the offer

@kevinksullivan
Copy link
Contributor

Payment sent and contract ended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

6 participants