Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-08-16] [$250] Migrate TextInputLabel/index.native.js to function component #16207

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 47 comments
Closed
1 task

[HOLD for payment 2023-08-16] [$250] Migrate TextInputLabel/index.native.js to function component #16207

marcaaron opened this issue Mar 20, 2023 · 47 comments
Assignees
@eVoloshchak @laurenreidexpensify @hayata-suenaga @devanshu-josh
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010ad9710b494cda73
  • Upwork Job ID: 1685092965701922816
  • Last Price Increase: 2023-07-29
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate index.native.js to function component [HOLD][$250] Migrate index.native.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@s-alves10

This comment was marked as spam.

Sign in to view
@vdem0115

This comment was marked as spam.

Sign in to view
@olexyt

This comment was marked as spam.

Sign in to view
@rayane-djouah
Copy link
Contributor

Can I work on this?

@mejed-alkoutaini
Copy link

I'm able to work on this if needed!

@KrAbhas
Copy link
Contributor

KrAbhas commented Jul 19, 2023

I can work on this

@marcaaron marcaaron changed the title [HOLD][$250] Migrate index.native.js to function component [$250] Migrate TextInputLabel/index.native.js to function component Jul 29, 2023
@marcaaron marcaaron added NewFeature Something to build that is a new item. and removed Improvement Item broken or needs improvement. labels Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Triggered auto assignment to @laurenreidexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@marcaaron marcaaron added the External Added to denote the issue can be worked on by a contributor label Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Job added to Upwork: https://www.upwork.com/jobs/~010ad9710b494cda73

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 31, 2023
@devanshu-josh
Copy link
Contributor

@eVoloshchak PR is ready for review!

@melvin-bot
Copy link

melvin-bot bot commented Aug 7, 2023

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

  • when @devanshu-josh got assigned: 2023-07-31 17:00:19 Z
  • when the PR got merged: 2023-08-07 13:38:49 UTC
  • days elapsed: 4

On to the next one 🚀

@laurenreidexpensify
Copy link
Contributor

Deployed to staging

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 9, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate TextInputLabel/index.native.js to function component [HOLD for payment 2023-08-16] [$250] Migrate TextInputLabel/index.native.js to function component Aug 9, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@devanshu-josh
Copy link
Contributor

@hayata-suenaga I'm not yet hired on upwork

@devanshu-josh
Copy link
Contributor

@hayata-suenaga please check, i'm not yet hired for the job on upwork.

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Aug 14, 2023 •
edited
Loading

@laurenreidexpensify could you check @devanshu-josh's comments above ⬆️ 🙇

Thank you for your PR @devanshu-josh I'm checking with the internal team about your comments. Thank you for your patience 🙇

@devanshu-josh
Copy link
Contributor

@laurenreidexpensify @hayata-suenaga please hire and pay. Today is the date for payment.

@hayata-suenaga
Copy link
Contributor

@devanshu-josh I believe @laurenreidexpensify has been partly OOO. I believe she will get back to you soon

@eVoloshchak
Copy link
Contributor

Requested the payment via NewDot

@JmillsExpensify
Copy link

@laurenreidexpensify Mind providing a payment summary for this PR/refactor?

@laurenreidexpensify laurenreidexpensify added Daily KSv2 and removed Weekly KSv2 labels Aug 18, 2023
@laurenreidexpensify
Copy link
Contributor

laurenreidexpensify commented Aug 18, 2023 •
edited
Loading

Payment summary:

External issue reporter - N/A
Contributor that fixed the issue - @devanshu-jos - $250 - offer sent in Upwork
Contributor+ that helped on the issue and/or PR - @eVoloshchak - $250 - payment requested in newdot

@laurenreidexpensify
Copy link
Contributor

Sorry for the delay here everyone, this was mislabelled as a weekly priority so I only go to review it today

@devanshu-josh
Copy link
Contributor

@laurenreidexpensify offer accepted!

@laurenreidexpensify
Copy link
Contributor

Updated Payment summary:

External issue reporter - N/A
Contributor that fixed the issue - @devanshu-jos - $250 - paid in Upwork
Contributor+ that helped on the issue and/or PR - @eVoloshchak - $250 - payment requested in newdot

@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@JmillsExpensify
Copy link

Reviewed the details for @eVoloshchak. $250 approved for payment in NewDot based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eVoloshchak eVoloshchak

@laurenreidexpensify laurenreidexpensify

@hayata-suenaga hayata-suenaga

@devanshu-josh devanshu-josh

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests