[HOLD for payment 2023-03-20] [$1000] Inconsistency when double click the avatar and the search in LHN

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App
2. Double click on the avatar in LHN
3. Observe that the Setting Page is opened and closed immediately
4. Double click on the search in LHN
5. Observe that the Search Page is opened and is not closed immediately (repeat if this doesn't happen immediately - it is very intermittent)

Expected Result:

The behavior when double click on the avatar and the search should be the same, and double-clicking should open and immediately close both drawers.

Actual Result:

There is inconsistent behavior when double click on the avatar and the search in LHN

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.79-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-03-06.at.15.58.32.mov

Recording.1632.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tienifr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678093471715189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01db64ae16c9fd7da6
• Upwork Job ID: 1632871565572890624
• Last Price Increase: 2023-03-06

[MelvinBot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[conorpendergrast]

I've reproduced extremely inconsistently in the web app on desktop (OSX, Chrome, v1.2.79-0). This appears to only happen around 1 in every 3 times that I double-click. I've updated the OP to reflect that

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01db64ae16c9fd7da6

[MelvinBot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[MelvinBot]

Triggered auto assignment to @MariaHCD (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[allroundexperts]

What is the expected behaviour here? Do we want to hide both drawers on double click? Or do we want to show them?

[Ollyws]

My proposal for #15632 (comment) will also fix this issue.

[conorpendergrast]

@allroundexperts Yes, that's what I would expect to happen. Updating the OP to reflect that, thanks!

@Ollyws Nice! I'll lean on @MariaHCD to review and confirm that too 👍

[muhammadbahroz]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistence when double click the avatar and the search in LHN #15692

What is the root cause of that problem?

Upon Double clicking on search button and avatar in LHN, both act differently as of now because in search due to textInput in the placeholder the text gets highlighted and input gets disabled due to focus shift rather on the avatar it closes right away, as it is supposed to do with search as well.

What changes do you think we should make in order to solve the problem?

We should capture the transition of the side modal, during transition and when everything have not been rendered yet we should disable the placeholder or we can delay the focus, this will resolve the search issue and both will then act consistently.

What alternative solutions did you explore? (Optional)

A quick fix would be to disable the double click on the search button since it certainly does nothing and then a delayed followed click should close the modal.

[MariaHCD]

Thanks for the proposals here! But I think this issue conflicts with #15632. Posting in that issue.

UPDATE: #15632 (comment)

[s77rt]

@muhammadbahroz Thanks for the proposal, as @MariaHCD stated we have two conflicting expected behaviours, once that's sorted please tag me again to review your proposal.

[MariaHCD]

Hey, all! As per #15632 (comment), the expected behavior is the one outlined in this issue.

@s77rt I think we're good to review the proposals here (and also any new proposals that may come in)

[muhammadbahroz]

@s77rt tagging you again, like you mentioned for the proposal review after getting clear from @MariaHCD.

[s77rt]

@muhammadbahroz Thanks for the proposal. I think your RCA is not correct, this issue is not strictly related to the text input.

[muhammadbahroz]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

• The root cause of the problem is the Loader in Search Modal, which is causing an issue with didScreenTransitionEnd.
• When there is already data available in sections, didTransitionScreenEnd returns false, leading to the issue with the Loader in the ternary operator.
• There is no issue with the Loader in the Settings Modal because it is not using didScreenTransitionEnd. This is a key difference from the issue in the Search Modal, where didScreenTransitionEnd is causing a problem with the Loader.

What changes do you think we should make in order to solve the problem?

• To solve the problem, we can adjust didScreenTransitionEnd or remove it entirely, as with preliminary tests it didn't leave any side effects.
• Another solution is to replace the ActivityIndicator with a different Loading Bar.

What alternative solutions did you explore? (Optional)

Alternatively, we can add a single check for the activity indicator instead of using a ternary operator.

I've also attached video that shows my given solution works and i'm also showing the live version of the website as well that currently has this issue

settings.and.avatar.issue.mp4

[muhammadbahroz]

@s77rt i've solved the issue and proposed a new solution for it.
I've also attached a screen recording for it that my solution new works.
Do check it out. Cheers 🥂

[s77rt]

@Ollyws Thanks for the proposal. I agree on the RCA, this is related to the browser behaviour on double click it will select. Preventing (double)selection is the way to go and I think your solution of disabling selection on navigationModalOverlay is good enough.

🎀 👀 🎀 C+ reviewed

cc @MariaHCD

[conorpendergrast]

@MariaHCD Just noting for myself to hire Ollyws if you agree

[MariaHCD]

I agree with @Ollyws's proposal as well 👍🏼

[MelvinBot]

📣 @Ollyws You have been assigned to this job by @MariaHCD!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Ollyws]

All yours @s77rt !

[conorpendergrast]

Following this SO, I'm inviting:

• The Contributor+ : @s77rt $1000 base
• The contributor fixing the issue: @Ollyws $1000 base
• The contributor who reported the issue/bug: @tienifr $250

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix for: Inconsistency when double click the avatar and the search in LHN #15769

If no regressions arise, payment will be issued on 2023-03-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt / @MariaHCD] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt / @MariaHCD] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt / @MariaHCD] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@conorpendergrast] Determine if we should create a regression test for the bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.
• [@conorpendergrast] Review the proposed regression test steps and location.
• [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Fix modal closing animation on web/desktop #1960
• The offending PR has been commented on: Fix modal closing animation on web/desktop #1960 (comment)
• A discussion in #expensify-bugs has been started: https://expensify.slack.com/archives/C049HHMV9SM/p1678726592060429

---

Regression Test Proposal

1. Double click on the search icon in LHN
2. • Desktop/Web: Verify that the Search Page is opened and closed immediately
   • Native/mWeb: Verify that the Search Page is opened and functions normally

[MelvinBot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[conorpendergrast]

This is due for payment today @stephanieelliott , but I'll be OoO flying back to Europe! Can you do that pleeeease?

[stephanieelliott]

All paid up, with an add'l speed bonus for C and C+!