[PAID] [HOLD for payment 2023-02-14] [$1000] Login - The line is green when incorrect password entered

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open NewDot app
2. Enter email
3. Click continue
4. Enter wrong password

Expected Result:

The line should be red or no focus when an invalid password is entered

Actual Result:

The line is green when incorrect password entered

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• iOS / native

Version Number: 1.2.60.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017759eff2106d5a57
• Upwork Job ID: 1619028067084832768
• Last Price Increase: 2023-02-02

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017759eff2106d5a57

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[strepanier03]

Bug0 Triage Checklist

Note: see this SO for more information.

• The "bug" is actually a bug
• The bug is not a duplicate report of an existing GH.
• The bug is reproducible, following the reproduction steps.
• The GH template is filled out as fully as possible
• The GH was created by an Expensify employee or a QA tester
• If the bug is an OldDot issue, you should decide whether it is widespread enough to justify fixing or it is better to wait for reunification. If it’s better to wait, close the GH & provide this justification
• If there's a link to Slack, check the discussion to see if we decided not to fix it
• Decide if the GH should be resolved by an External contributor or Internal engineer, add the appropriate label

[strepanier03]

I couldn't recreate this and realized I didn't have NewDot app on my android on staging. I'm working on getting it downloaded and then I'll finish testing.

[luacmartins]

I have a draft PR up for this and should work some more on it today!

[strepanier03]

@luacmartins I assume you were able to recreate this okay then right? I am struggling to get newdot staging app on my phone so I was going to ask in Slack for someone to test. It's not recreatable on prod for me.

If you can recreate and feel it's a legit bug I will take your testing as confirmation and move this forward.

[luacmartins]

@strepanier03 yes, I can reproduce this and I'm working on a fix for it. What issues are you having with installing the staging App?

[strepanier03]

Thanks for your help in Echat @luacmartins - I'm all set on staging now and can recreate this as well.

[melvin-bot]

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

[melvin-bot]

Upwork job price has been updated to $1000

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.66-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add error to login input #14627

If no regressions arise, payment will be issued on 2023-02-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - None, internal report
• Contributor that fixed the issue - None, internal fix
• Contributor+ that helped on the issue and/or PR - @aimane-chnaif
• Note: No speed bonus applies here.

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif / @luacmartins] The PR that introduced the bug has been identified. Link to the PR: Unable to find a PR that caused this bug. Pretty sure it existed from the beginning.
• [@aimane-chnaif / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Propose regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[strepanier03]

Updated the payment checklist and am working on the reg test step now.

[luacmartins]

@aimane-chnaif would you mind working on the BZ checklist?

[aimane-chnaif]

I don't think any PR caused this regression. This bug existed from the beginning when sign in pages are implemented.

[aimane-chnaif]

Regression Test Proposal

• I think this test should be applied to all inputs across the app.
• So when invalid value entered on any input and form error message shows below it, border bottom line should also become red.
• Do we agree 👍 or 👎

[strepanier03]

Oooh, I didn't realize that the regression proposal changed to the C+ now and wasn't part of my steps in the checklist.

The way our regression tests are written we'd need to add tests for every input or update every test that has an input step. I'm not 100% sure what the best practice is there. I'll wait for @luacmartins to weigh in but I'm thinking our options are:

• Look at TestRail for all scenarios dealing with inputs and add steps to check for the bottom border being red in each one,
• Find the reg test in TestRail that looks at this input specifically and update it,
• Or I guess potentially having a mini-project to check each input and ensure we're consistent across them all?

[luacmartins]

IIRC the way we handle these is to add a description under the Expected results section in TestRail for tests handling inputs with validation.

[strepanier03]

@luacmartins - Sounds good. How do I know which field inputs have validation on them so I can narrow down which tests we need to update?

[luacmartins]

I think that we should include the pages below, because they don't use our Form component but should behave similarly. Other inputs are handled by the Form component and I don't think we need to worry about those here.

• Add secondary login page - Settings > Profile > Phone number
• New password page - Settings > Security > Change password
• Add PayPal.me page - Settings > Payments > Add payment method > Paypal.me
• Email input in Login page
• Password input in Login page
• Validate input in Login page

[strepanier03]

Thank you @luacmartins - I'll work on the GH for this tomorrow.

I've also updated the checklist with Aimane's comment regarding the PR that intro'd the bug and will be ready to pay out Upwork tomorrow.

[strepanier03]

@aimane-chnaif - I've sent an invite to the job directly to you, once you accept I'll send the offer and check back in this afternoon to see if I can pay it out.

[strepanier03]

Just sent the offer @aimane-chnaif - Before I leave today I'll check again and if it's accepted I'll pay out, otherwise I'll check again tomorrow.

[strepanier03]

GH for the reg test is here. I'm still discussing some things on the reg test buddy check but I made the GH so this GH could be closed.

Thanks again @aimane-chnaif!